search

CiscoDevNet / terraform-provider-aci

Terraform Cisco ACI provider
https://registry.terraform.io/providers/CiscoDevNet/aci/latest/docs
Mozilla Public License 2.0
91 stars 101 forks source link

Removed legacy route_control_profile resource files #1259

Closed sajagana closed 3 months ago

sajagana commented 4 months ago

Note:

Recreated route_control_profile resource using the generator.

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 87.37864% with 78 lines in your changes missing coverage. Please review.

Project coverage is 84.76%. Comparing base (d260d17) to head (fbc734b).

Files Patch % Lines
...nal/provider/resource_aci_route_control_profile.go 86.00% 45 Missing and 25 partials :warning:
.../provider/data_source_aci_route_control_profile.go 93.10% 6 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1259 +/- ## ========================================== + Coverage 84.72% 84.76% +0.04% ========================================== Files 91 93 +2 Lines 33600 34218 +618 ========================================== + Hits 28466 29006 +540 - Misses 3830 3881 +51 - Partials 1304 1331 +27 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

akinross commented 3 months ago

Please re-run v6.0 tests in CI to succeed. This should be done when other CI are not running towards the apic.