search

CiscoDevNet / terraform-provider-aci

Terraform Cisco ACI provider
https://registry.terraform.io/providers/CiscoDevNet/aci/latest/docs
Mozilla Public License 2.0
91 stars 101 forks source link

Removed check to test resource attributes when ImportStateVerify is set to true in resource tests #1265

Closed shrsr closed 3 months ago

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.05%. Comparing base (002e50f) to head (042dfc7). Report is 3 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1265 +/- ## ======================================= Coverage 84.05% 84.05% ======================================= Files 61 61 Lines 17940 17940 ======================================= Hits 15080 15080 Misses 2054 2054 Partials 806 806 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

samiib commented 3 months ago

Sorry maybe a silly question but just wondering, why we needed to remove the attribute checks when ImportStateVerify is true?

shrsr commented 3 months ago

@samiib When ImportStateVerify is set to True, Terraform automatically verifies that the state of the imported resource matches the expected state. The steps in the Check are ignored when the above field is True.