CiscoDevNet / terraform-provider-aci

Terraform Cisco ACI provider
https://registry.terraform.io/providers/CiscoDevNet/aci/latest/docs
Mozilla Public License 2.0
91 stars 101 forks source link

[minor_change] Add resources and datasources to support qosDot1PClass and qosDscpClass and expose them in existing aci_custom_qos_policy resource and datasource as children (DCNE-35) #1296

Open akinross opened 1 week ago

akinross commented 1 week ago

fixes #1267

codecov-commenter commented 1 week ago

Codecov Report

Attention: Patch coverage is 89.97240% with 218 lines in your changes missing coverage. Please review.

Project coverage is 83.97%. Comparing base (24898fb) to head (a9def98). Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
internal/provider/resource_aci_dot1p_classifier.go 85.71% 67 Missing and 25 partials :warning:
...rnal/provider/resource_aci_dscp_to_priority_map.go 85.71% 67 Missing and 25 partials :warning:
...nternal/provider/resource_aci_custom_qos_policy.go 97.59% 8 Missing and 4 partials :warning:
...ernal/provider/data_source_aci_dot1p_classifier.go 92.30% 9 Missing and 2 partials :warning:
...l/provider/data_source_aci_dscp_to_priority_map.go 92.30% 9 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1296 +/- ## ========================================== + Coverage 83.74% 83.97% +0.23% ========================================== Files 123 127 +4 Lines 56180 58350 +2170 ========================================== + Hits 47049 49001 +1952 - Misses 7255 7415 +160 - Partials 1876 1934 +58 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

akinross commented 2 days ago

have you tried to see what happens with these class objects when priority is set to unspecified?

just double checked and it sets to unspecified for both classes, also checked the target_cos attribute