Closed jgomezve closed 2 months ago
@danischm
Couple of comments questions about this PR:
The attribute protocol_instance is used in the dn. Thus id: True. For static and direct protocols this should be set to none, I was expecting to use a default value, but default values do not work for attributes with id: True. I decided then to put this information in the attribute description https://github.com/CiscoDevNet/terraform-provider-nxos/blob/22ea257d247f37b905cf1ffded154de0a85f1bf2/gen/definitions/bgp_route_redistribution.yaml#L72
protocol_instance
dn
id: True
static
direct
none
What about improving the logic of the .tf example to just considers the attributes with the key example set ? For this particular resource I did not set the example key for the attribute srv6_prefix_type. Nonetheless, it is still shown in the .tf example. https://github.com/CiscoDevNet/terraform-provider-nxos/blob/jg-bgp-interleak/examples/resources/nxos_bgp_route_redistribution/resource.tf
.tf
example
srv6_prefix_type
@danischm
Couple of comments questions about this PR:
The attribute
protocol_instanceis used in thedn. Thusid: True. Forstaticanddirectprotocols this should be set tonone, I was expecting to use a default value, but default values do not work for attributes withid: True. I decided then to put this information in the attribute description https://github.com/CiscoDevNet/terraform-provider-nxos/blob/22ea257d247f37b905cf1ffded154de0a85f1bf2/gen/definitions/bgp_route_redistribution.yaml#L72What about improving the logic of the
.tfexample to just considers the attributes with the keyexampleset ? For this particular resource I did not set theexamplekey for the attributesrv6_prefix_type. Nonetheless, it is still shown in the.tfexample. https://github.com/CiscoDevNet/terraform-provider-nxos/blob/jg-bgp-interleak/examples/resources/nxos_bgp_route_redistribution/resource.tf