search

CiscoDevNet / virl2-client

Client library for the Cisco VIRL 2 Network Simulation Platform
Apache License 2.0
56 stars 18 forks source link

SIMPLE-5729 uploading image files now keeps the extension, removed old deprecated parameter from upload_image_file #50

Closed daniel-valent closed 1 year ago

daniel-valent commented 1 year ago

So I thought there were some inefficiencies in upload_image_file... And when I fixed them, all related test died. So never mind that. Don't touch the Path related things, something about the way they are imported makes them fragile.

E: Found what the problem was - we are testing Windows paths on Linux, so we have to use PureWindowsPath instead of WindowsPath in tests, which means no interaction with system, which means no Path.exists(). Means that my changes worked fine, but broke tests.

daniel-valent commented 1 year ago

Tests pass, every seems (finally) ready to merge, unless there are further comments.