CiscoDevNet / webex-contact-center-widget-starter

WebEx Contact Center widget starter
MIT License
25 stars 43 forks source link

Added Learning Sample #30

Closed sameer0440 closed 3 years ago

sameer0440 commented 3 years ago

Types of changes

Please check if the PR fulfills these requirements

What kind of change does this PR introduce?

(Bug fix, feature, docs update, ...)

Added a new learning sample widget which is a replica of popular finesse learning sample gadget that helps in understanding the basics of gadgets

What is the current behavior?

(You can link to an open issue)

[Type here]

What is the new behavior

(if this is a feature change)?

[Type here]

Does this PR introduce a breaking change?

(What changes might users need to make in their application due to this PR?)

NO

Other information:

NA

yananym commented 3 years ago

So how is this different from Lit Element widget starter?

sameer0440 commented 3 years ago

This is replica of a popular Finesse gadget so people can compare, understand and learn.

futurethang commented 3 years ago

I agree that this seems to cause a bit of duplication in the wrong area. What if we made the changes to the documentation at the top level, the lit-element starter directory, so people get that help with building the dist and adding it to their project config. For the Finesse widget, I'd say make it a full implementation of the known gadget as a web component following the Lit Element structure, but not just a hypothetical sample.

yananym commented 3 years ago

I agree that this seems to cause a bit of duplication in the wrong area. What if we made the changes to the documentation at the top level, the lit-element starter directory, so people get that help with building the dist and adding it to their project config. For the Finesse widget, I'd say make it a full implementation of the known gadget as a web component following the Lit Element structure, but not just a hypothetical sample.

Agreed with Kevin

elenagiere commented 3 years ago

I agree that this seems to cause a bit of duplication in the wrong area. What if we made the changes to the documentation at the top level, the lit-element starter directory, so people get that help with building the dist and adding it to their project config. For the Finesse widget, I'd say make it a full implementation of the known gadget as a web component following the Lit Element structure, but not just a hypothetical sample.

I agree with Kevin

sameer0440 commented 3 years ago

If someone knows the finesse learning gadget he can easily understand what change he need to do achieve similar functionality .This is purely to build an understanding .Even if it is duplicate it is just an example and it is not causing any harm to the users desktop. I have added readme notes on building the project so it is not dependent on the lit element starter directory and its documentation.

futurethang commented 3 years ago

@sameyada I think what we are missing here then is a fully working sample that users can launch locally like the other current Example widgets. I'm unable to get the widget to run myself, so perhaps I am missing something?

sameer0440 commented 3 years ago

@futurethang I am bit confused here. Is that mandatory that all example widgets should be runnable locally ?? because widgets will be fetching data from the interactions and agent desktop so why it need to be run locally ??