ygorelik
commented
5 years ago Fixed the issue in libyang. After recompiling YDK with libyang code changes and building python core package repeated the above test:
#!/usr/bin/env python
#
# Copyright 2016 Cisco Systems, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
"""
Encode configuration for model openconfig-acl.
usage: cd-encode-oc-acl-30-ydk.py [-h] [-v] device
optional arguments:
-h, --help show this help message and exit
-v, --verbose print debugging messages
"""
from argparse import ArgumentParser
import logging
import sys
if sys.version_info > (3,):
from urllib.parse import urlparse
else:
from urlparse import urlparse
from ydk.services import CodecService
from ydk.providers import CodecServiceProvider
from ydk.models.openconfig import openconfig_acl \
as oc_acl
def config_acl(acl):
"""Add config data to acl object."""
# acl-set configuration
acl_set = acl.AclSets.AclSet()
acl_set.name = "ACL1"
acl_set.type = oc_acl.ACLIPV4()
acl_set.config.name = "ACL1"
acl_set.config.type = oc_acl.ACLIPV4()
acl_set.acl_entries = acl_set.AclEntries()
# acl-entry with sequence number 10
acl_entry = acl_set.acl_entries.AclEntry()
acl_entry.sequence_id = 10
acl_entry.config.sequence_id = 10
acl_set.acl_entries.acl_entry.append(acl_entry)
# acl-entry with sequence number 20
acl_entry = acl_set.acl_entries.AclEntry()
acl_entry.sequence_id = 20
acl_entry.config.sequence_id = 20
acl_entry.actions.config.forwarding_action = oc_acl.ACCEPT()
acl_entry.ipv4.config.source_address= "172.31.255.1/32"
acl_set.acl_entries.acl_entry.append(acl_entry)
# acl-entry with sequence number 30
acl_entry = acl_set.acl_entries.AclEntry()
acl_entry.sequence_id = 30
acl_entry.config.sequence_id = 30
acl_entry.actions.config.forwarding_action = oc_acl.REJECT()
acl_set.acl_entries.acl_entry.append(acl_entry)
acl.acl_sets.acl_set.append(acl_set)
if __name__ == "__main__":
"""Execute main program."""
parser = ArgumentParser()
parser.add_argument("-v", "--verbose", help="print debugging messages",
action="store_true")
args = parser.parse_args()
# log debug messages if verbose argument specified
if args.verbose:
logger = logging.getLogger("ydk")
logger.setLevel(logging.INFO)
handler = logging.StreamHandler()
formatter = logging.Formatter(("%(asctime)s - %(name)s - "
"%(levelname)s - %(message)s"))
handler.setFormatter(formatter)
logger.addHandler(handler)
# create codec provider
provider = CodecServiceProvider(type="xml")
# create codec service
codec = CodecService()
acl = oc_acl.Acl() # create object
config_acl(acl) # add object configuration
# encode and print object
print(codec.encode(provider, acl))
exit()Run results:
(venv) ygorelik@bionic:~/ydk-gen$ python scripts/samples/cd-encode-oc-acl-30-ydk.py -v
<acl xmlns="http://openconfig.net/yang/acl">
<acl-sets>
<acl-set>
<name>ACL1</name>
<type>ACL_IPV4</type>
<config>
<name>ACL1</name>
<type>ACL_IPV4</type>
</config>
<acl-entries>
<acl-entry>
<sequence-id>10</sequence-id>
<config>
<sequence-id>10</sequence-id>
</config>
</acl-entry>
<acl-entry>
<sequence-id>20</sequence-id>
<config>
<sequence-id>20</sequence-id>
</config>
<ipv4>
<config>
<source-address>172.31.255.1/32</source-address>
</config>
</ipv4>
<actions>
<config>
<forwarding-action>ACCEPT</forwarding-action>
</config>
</actions>
</acl-entry>
<acl-entry>
<sequence-id>30</sequence-id>
<config>
<sequence-id>30</sequence-id>
</config>
<actions>
<config>
<forwarding-action>REJECT</forwarding-action>
</config>
</actions>
</acl-entry>
</acl-entries>
</acl-set>
</acl-sets>
</acl>The codec worked with no issues.
horseinthesky
Current Behavior
Parsing of data based on openconfig models is causing YModelError exception due to failure to match string value with model defined patterns. The errors are similar to this:
The Google OpenConfig group has adopted POSIX regular expressions for coding string patterns in YANG modules "due to the lack of widely available software implementations for the W3C standard".
As per RFC 6020, the pattern string should follow the rules according to the XSD types https://tools.ietf.org/html/rfc6020#page-119, according to which the '^' and '$' character is taken literally as part of the regex and not as an indication of head and tail.
The Google team claimed that they are not going to change their YANG models and any such issues must be resolved locally in YANG model parsers. So the '^' character in the beginning of pattern string and '$' at the end needs to be removed automatically.
Steps to Reproduce
Try to run sample example from here using standard installation of ydk-models-openconfig package.
Logs
Enable logging and post the logs below
Observe this or similar error in the log:
System Information
YDK-0.8.4