search

CiscoISE / terraform-provider-ciscoise

Terraform Provider for Cisco ISE
https://registry.terraform.io/providers/CiscoISE/ciscoise/latest/docs
MIT License
9 stars 4 forks source link

Fixes for issues #89 #104 #105 #106 in terraform provider and #32 in ciscoise-go-sdk #33 #107

Closed kuba-mazurkiewicz closed 9 months ago

kuba-mazurkiewicz commented 11 months ago

Fixes for issues #89 #104 #105 #106 in terraform provider and #32 in ciscoise-go-sdk #33

jbogarin commented 11 months ago

ISE 3.2 is not currently supported. Once we release a version of the provider for ISE 3.2, we will review this PR. However, all the files have this change: isegosdk "github.com/kuba-mazurkiewicz/ciscoise-go-sdk/sdk" instead of: isegosdk "github.com/CiscoISE/ciscoise-go-sdk/sdk"

Which breaks everything in the provider.

kuba-mazurkiewicz commented 11 months ago

i cannot test it if i don't change github url to fork one. Anyway u are closing PRs and taking changes opening yours, so i was not changing it back.

Sent from my iPhone

On 13 Sep 2023, at 19:44, Jose Bogarín Solano @.***> wrote:



ISE 3.2 is not currently supported. Once we release a version of the provider for ISE 3.2, we will review this PR. However, all the files have this change: isegosdk "github.com/kuba-mazurkiewicz/ciscoise-go-sdk/sdk" instead of: isegosdk "github.com/CiscoISE/ciscoise-go-sdk/sdk"

Which breaks everything in the provider.

— Reply to this email directly, view it on GitHubhttps://github.com/CiscoISE/terraform-provider-ciscoise/pull/107#issuecomment-1718055857, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A7TQSALE535MWUOSN2PE22LX2HWGLANCNFSM6AAAAAA4VQ3ZJY. You are receiving this because you authored the thread.Message ID: @.***>

kuba-mazurkiewicz commented 11 months ago

issues #104, #105, #106 are for ISE 3.1.