search

CiscoTestAutomation / genielibs

genie.libs contains libraries for configuring, retrieving and testing topologies
Apache License 2.0
109 stars 55 forks source link

Add verify_eigrp_interfaces_timers API to verify.py ios/iosxe eigrp protocol #166

Closed cherifimehdi closed 3 months ago

cherifimehdi commented 5 months ago

Hello, I added new API verify_eigrp_interfaces_timers to verify.py ios/iosxe eigrp protocol (my old contribution) supporting EIGRPv4 and EIGRPv6 for IOS/IOSXE https://github.com/CiscoTestAutomation/genielibs/pull/165 Thanks

Neeraja1bala commented 5 months ago

Hello @cherifimehdi ,

Kindly give some time, will check and update you.

cherifimehdi commented 5 months ago

Hello @cherifimehdi ,

Kindly give some time, will check and update you.

Thank you. But I try to contact the reviewers to resolve the problem of tests fail since I closed before a PR just for this and I opened the current PR for this reason

Neeraja1bala commented 5 months ago

Hello @cherifimehdi ,

Can you please check the version of genie is 24.4.3.

cherifimehdi commented 5 months ago

Hello @cherifimehdi ,

Can you please check the version of genie is 24.4.3.

I have genie==23.11, perhaps this is the problem?

Neeraja1bala commented 5 months ago

Can you please update, try to push to PR and let us know.

cherifimehdi commented 5 months ago

Hi @Neeraja1bala thank you very much. Finally test passed after updating pyATS/Genie and uploading a new test files. All that remains is to review the PR. Thank you so much

Neeraja1bala commented 5 months ago

Hello @cherifimehdi ,

Thanks for confirmation. Kindly follow up the reviewers to review.

cherifimehdi commented 5 months ago

Hello @cherifimehdi ,

Thanks for confirmation. Kindly follow up the reviewers to review.

Thank you @Neeraja1bala

cherifimehdi commented 5 months ago

Hi @Neeraja1bala could you please contact the reviewers as I made changes and contacted them 02 weeks ago with no response THANKS

cherifimehdi commented 4 months ago

Hi @Neeraja1bala broken tests when I synced the fork to update the branch! please what is the problem?

cherifimehdi commented 4 months ago

Hi @ParimiNeeraja broken tests when I synced the fork to update the branch! please what is the problem?

cherifimehdi commented 4 months ago

Hello @Neeraja1bala @ParimiNeeraja still no answer and solution?

Neeraja1bala commented 4 months ago

Hello @cherifimehdi ,

Can you give some time, will check and update you.

Neeraja1bala commented 4 months ago

Hello @cherifimehdi ,

I am fetching your branch to test in my end, but not able to fetch getting below error,

ssh: Could not resolve hostname cherifimehdi: Name or service not known
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

Kindly help to fetch your branch to test.

cherifimehdi commented 4 months ago

Hello @cherifimehdi ,

I am fetching your branch to test in my end, but not able to fetch getting below error,

ssh: Could not resolve hostname cherifimehdi: Name or service not known
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

Kindly help to fetch your branch to test.

Hi @Neeraja1bala I think the problem resides in the last update of pyATS. I notice there is a problem in the test of the last update and it seems it was fail. Here the link to the master repo https://github.com/CiscoTestAutomation/genielibs/tree/master There is fail state!

cherifimehdi commented 4 months ago

Hi @Neeraja1bala I found this in Test Unit Tests in Run Tests / build (3.11) , please what is the reason:

ERROR:pyats.aetest.steps.implementation:Failed reason: The following arithmetic statement 3 == 3 and 2 ==1 is False

cherifimehdi commented 4 months ago

Hi @Neeraja1bala @ParimiNeeraja Now test PASSED after I made update for my branch. I think there was a problem in the prvious version!

cherifimehdi commented 4 months ago

Hi @Neeraja1bala can you please ask @lsheikal @SohanTirpude to review my PR? Thanks

cherifimehdi commented 3 months ago

Hi @Neeraja1bala @ParimiNeeraja , @Taarini approved my PR on May 31, please can you approve or review if there is anything else to modify cause it's been almost two months? THANKS

Neeraja1bala commented 3 months ago

Hello @cherifimehdi ,

Yes, i am checking with them to approve the PR.

cherifimehdi commented 3 months ago

Hello @cherifimehdi ,

Yes, i am checking with them to approve the PR.

Thank you @Neeraja1bala but unfortunately there is still no answers from @lsheikal and @SohanTirpude

cherifimehdi commented 3 months ago

Hello, since this PR is merged I will close this issue. Thank you

cherifimehdi commented 3 months ago

Thanks