CiscoTestAutomation / pyats

Cisco DevNet pyATS Test Framework Bug Tracker
Apache License 2.0
148 stars 31 forks source link

pyats-log 23.1 depends on python-engineio<4.0.0 and >=3.13.0 #204

Open alurmtr opened 1 year ago

alurmtr commented 1 year ago

I am working on a project that requires a newer version of python-engineio and python-socketio. Any way to compile pyats-log to work with the latest version of python-engineio or at least > 4.3.4

Same for python-socketio, pyats has a limitation for python-socketio<=5.0. python-socketio, It is up to 5.7

thanks

Al

iamsatyanarayan commented 1 year ago

Hi , I am looking at your ticket and reviewing it, Please let me know are you facing the issue still or not ?

alurmtr commented 1 year ago

Hello, yes still seeing this issue.

ghost commented 1 year ago

Hi alurmtr, To compile pyats-log to work with the latest version of python-engineio or at least version 4.3.4, you can try the following steps:

Update python-engineio and python-socketio: Upgrade python-engineio and python-socketio to the latest version using the package manager of your choice (e.g., pip, conda). Example :- pip install python-engineio==4.4.1

Install the necessary dependencies: Make sure all necessary dependencies for pyats-log are installed, including the latest versions of python-engineio and python-socketio.

Modify the source code: Locate the pyats-log source code and modify any references to the older version of python-engineio to the new version (e.g., replace "python-engineio==4.0.0" with "python-engineio>=4.3.4").

Compile and test: Compile pyats-log and test it thoroughly to ensure it works correctly with the latest version of python-engineio and python-socketio.

ghost commented 1 year ago

Hi alurmtr, Did you try with this command in your environment ?

ghost commented 1 year ago

Hi alurmtr, Could you please let me know the issue status ?

ghost commented 1 year ago

Hi alurmtr, As we haven't heard back from you , we will be closing this ticket. If you still require further assistance, please feel free to open a new ticket.

alurmtr commented 1 year ago

Are you referring to modifying the site-packages/pyats.log-23.1.dist-info/METADA file? Requires-Dist: python-socketio (<5.0.0,>=4.2.0) Requires-Dist: python-engineio (<4.0.0,>=3.13.0)

Are there plans to make this change in the next pyats release?

iamsatyanarayan commented 1 year ago

Hi alurmtr, First of all Update python-engineio and python-socketio: Upgrade python-engineio and python-socketio to the latest version using the package manager of your choice (e.g., pip). Example :- pip install python-engineio==4.4.1

i am not sure they are planning to make this change in the next pyats release. If it won't work after update. The we need to do some changes.

iamsatyanarayan commented 1 year ago

Hi alumtr, Could you please let me known any update on your issue ?

iamsatyanarayan commented 1 year ago

Hi alumtr, Could you please let me known any update on your issue ?

iamsatyanarayan commented 1 year ago

Hi alumtr, As we haven't heard back from you and your PR already merged .we will be closing this ticket. If you still require further assistance, please feel free to open a new ticket.

alurmtr commented 1 year ago

I haven't had the chance to try out your workaround. I was hoping the libraries be update as you roll out the next pyats version. I have a gitlab pipeline that installs these packages, so if the intention is to somehow make the change you propose on the fly, it will be very difficult.

simingy commented 1 year ago

python-socketio and python-engineio version pinning is due to the major version update moving to newer version of that protocol

upgrading to the new version (eg 5) would also require local log viewer ui and xpresso ui to be upgraded, both are a fairely significant effort.

not a build/compilation fixable problem