CiscoUcs / ucsmsdk

Python SDK for Cisco UCSM
Other
80 stars 60 forks source link

Changes for pyparsing compat with 2.4.7 and 3.0; some parser cleanup #218

Closed ptmcg closed 2 years ago

ptmcg commented 2 years ago

Replace deprecated operatorPrecedence with backward-compat infixNotation Use Word(asKeyword=True) in place of WordStart Remove unnecessary Forwards Use Keyword in place of Literal Ensure matching opening and closing quotes on types and flags

ptmcg commented 2 years ago

Glad you could incorporate these changes!

Shashank-Pandey-ML commented 2 years ago

Hi @ptmcg, I don't see your changes being merged in master. Can I know the reason why you closed this PR?

ptmcg commented 2 years ago

I was under the impression that these changes were subsumed into the other PR's. If that is incorrect, then go ahead and reopen it, or replicate it to a new one.

Shashank-Pandey-ML commented 2 years ago

Thanks @ptmcg, I have replicated the PR.