search

Citadel-DAO / citadel-contracts

Citadel DAO Core Contracts
31 stars 11 forks source link

Fix Test CI for PRs from Forks #150

Open sajanrajdev opened 2 years ago

sajanrajdev commented 2 years ago

Currently, PRs opened from a fork seem to be failing their Test CI job with the following:

image

Needs further investigation...

shuklaayush commented 2 years ago

This is because repository secrets (ALCHEMY_KEY in our case) are not available to workflows originating from a fork due to security reasons

sajanrajdev commented 2 years ago

This is because repository secrets (ALCHEMY_KEY in our case) are not available to workflows originating from a fork due to security reasons

@shuklaayush, thanks for the insights. Good to know! I looked deeper into this and found that there are no plans from GH to allow this in the future. It would probably not make sense for us to allow it either way.

My suggestion is that we either ask contributors to PR from the base repo (@Ajand and @brianendo) or, if not possible, to include an ScreenShot of the tests passing for them locally within their PR.

For the moment, these two PRs are failing with this error: