search

Citadel-DAO / citadel-contracts

Citadel DAO Core Contracts
31 stars 11 forks source link

Test new Locker access control paradigm #81

Closed dapp-whisperer closed 2 years ago

dapp-whisperer commented 2 years ago

(Flagging for myself in the future)

Locker now uses GAC ACL, tests should be modified to reflect this.

sajanrajdev commented 2 years ago

Locker GAC Roles ACL is only partially tested within some of the flows n this repo. Three functions check for reverts on GAC permissions when there are 8 permissioned functions in the contract.

@Fatimanaz, we should extract permissions test for the locker into a centralized location as we did for the rest of the contracts. In this case, I suggest that we do it wihtin the staked-citadel-locker repo for better change/testing flow resilience. You can add Roles test to the GlobalAccessControl.t.sol test suite like you did in this repo.

sajanrajdev commented 2 years ago

Tackled through: https://github.com/Citadel-DAO/staked-citadel-locker/pull/9/files