search

Citi / gradle-helm-plugin

A suite of Gradle Plugins for building, publishing and managing Helm Charts
https://citi.github.io/gradle-helm-plugin
MIT License
9 stars 6 forks source link

Support for download of ARM binaries for Macs #68

Open gwidion opened 2 months ago

gwidion commented 2 months ago

Downloading helm client on Mac will always download amd64 binaries.

    fun getOperatingSystemClassifier() =
        when {
            osName.startsWith("Mac OS X") ->
                "darwin-amd64"

I think this should easily allow downloading arm64 binaries when appropriate.

fun getOperatingSystemClassifier() = 
    when {
        osName.startsWith("Mac OS X") -> 
            when (osArch) {
                "aarch64" -> "darwin-arm64"
                else -> "darwin-amd64"
            }
gwidion commented 1 month ago

any progress? should I open a MR?

JamieSlome commented 1 month ago

@gwidion - if you have changes you'd like to suggest, please feel free to open a pull request! 👍