CitiesSkylinesMods / TMPE

Cities: Skylines Traffic Manager: President Edition
https://steamcommunity.com/sharedfiles/filedetails/?id=1637663252
MIT License
576 stars 85 forks source link

Bus routes should respect 1 way routes in buildings #10

Open originalfoo opened 5 years ago

originalfoo commented 5 years ago

This is vital for correct operation of various bus terminals (both vanilla and workshop): https://github.com/VictorPhilipp/Cities-Skylines-Traffic-Manager-President-Edition/issues/230

krzychu124 commented 5 years ago

Indeed something is broken... 😞

I have one question. I haven't played some time. Is that behavior when vehicle can't cross center of road segment (i.e. is going straight and wants to turn left to factory) is it mod feature or vanilla?

originalfoo commented 5 years ago

Ok, I think there are two issues at play here:

1. Lane direction in building is ignored

I think this issue is caused by the mod, as asset creators show their assets working properly with vanilla routing. The following image show correct behaviour of the assets.

Bus Station asset: correct behaviour in vanilla

922683980_preview_screenshot 8

Non-stop Bus Station asset: correct behaviour in vanilla

868718614_preview_screenshot 11

Note the multiple entrances but single exit above.

Same station, this time sandwiched between two roads; busses can now use multiple exits: correct behaviour in vanilla

868718614_preview_screenshot 12

The above images show that in vanilla, the bus routes correctly adhere to the internal lane directions within the building.

As far as I can tell, TMPE is ignoring the lane directions for the 'roads' inside the building.

2. Vehicles not crossing road to enter a building on other side

EDIT: Created a dedicated issue for this; should be linked in reference notification below...

originalfoo commented 5 years ago

Another factor to bear in mind: The pathfinder, at least in TMPE, obviously weights in favour of bus lanes. This could make a longer route, consisting of dedicated bus lane, look more attractive to the pathfinder than a slightly shorter route of normal road?

originalfoo commented 5 years ago

I think #19 would be worth resolving first as that's going to affect all traffic, not just busses.

originalfoo commented 5 years ago

Just thought of another potential issue: If the bus stations are designed for drive-on-right style traffic, will that cause problems if player sets up a game where vehicles are driving on the left?

Are there things like entry/exit spawn points in bus stations (like there are, or should be, in cargo stations)?

In either case, there might also be some need to invert lane routing in the building (if that doesn't happen automatically based on map's drive direction)?

originalfoo commented 5 years ago

And another thing... It could possibly also be related to lanes inside buildings being negatively weighted?

Something like that seems to be happening for pedestrians, possibly causing things like https://github.com/VictorPhilipp/Cities-Skylines-Traffic-Manager-President-Edition/issues/144 and https://github.com/VictorPhilipp/Cities-Skylines-Traffic-Manager-President-Edition/issues/182 and https://github.com/VictorPhilipp/Cities-Skylines-Traffic-Manager-President-Edition/issues/115 - maybe it happens with vehicles too, eg. to avoid vehicles regularly taking shortcuts through buildings?

krzychu124 commented 5 years ago

Ok, so If we look closely to my first or second screenshot it's not bug. It's feature which gives you ability to function that bus stop in-between roads like that on one of images you posted. It's unfortunate connection of road and building. It will happen every time that Bus station is placed with road on their sides. In my case regarding to images you've added I have seen identical behavior(woked like in vanilla). Could you post an image with invalid path (ignored internal lane directions)?

originalfoo commented 5 years ago

The screenshots I posted above were examples of 'correct behaviour', taken from the workshop pages of the assets. Those screenshots, as best I can tell, were taken with vanilla game.

What was happening to me is that the lane directions were being ignored, so I was getting busses exiting from entrances, etc.

Next time I'm in game I'll take some screenies showing the problem I was having, assuming it's still happening.

krzychu124 commented 5 years ago

Thanks, anyway I will try to check that too ;)