CitiesSkylinesMods / TMPE

Cities: Skylines Traffic Manager: President Edition
https://steamcommunity.com/sharedfiles/filedetails/?id=1637663252
MIT License
574 stars 85 forks source link

Refactor remainder of `Policies` tab groups #1455

Closed originalfoo closed 2 years ago

originalfoo commented 2 years ago

Compiled mod for testing: TMPE.zip

Part of ongoing work on #1356 phase 2.

This completes phase 2 refactor of all mod options groups.

Closes: #62

kianzarrin commented 2 years ago

Path of evil is default value in new game. is this expected? I remember it used to be minor complaints. image

kianzarrin commented 2 years ago

Also "vehicles going straight on can change lane on junctions" is on by default. Isn't that illegal in the real world? image

originalfoo commented 2 years ago

Path of evil is default value in new game. is this expected? I remember it used to be minor complaints.

Good catch!

Looking at Options.cs before I started altering stuff:

https://github.com/CitiesSkylinesMods/TMPE/blob/23ee4b2e0c1f90e994296ccaeff82ab0854eb3ed/TLM/TLM/State/Options.cs#L30

new[] {
    Translation.Options.Get("Gameplay.Dropdown.Option:Path Of Evil (10%)"), // 0 
    Translation.Options.Get("Gameplay.Dropdown.Option:Rush Hour (5%)"), // 1
    Translation.Options.Get("Gameplay.Dropdown.Option:Minor Complaints (2%)"), // 2
    Translation.Options.Get("Gameplay.Dropdown.Option:Holy City (0%)"), // 3
},

So yeah, should be Holy City (0%). Will send commit to fix.

Also "vehicles going straight on can change lane on junctions" is on by default. Isn't that illegal in the real world?

Another good catch! Should be off by default, will update in next commit.

originalfoo commented 2 years ago

@kianzarrin Fixed bugs you spotted.

originalfoo commented 2 years ago

@kvakvs Is there any changes you specifically want in this PR or can comments above be left until next phase of updates to options stuff?

kianzarrin commented 2 years ago

I checked WS TMPE and this build and found more differences. Not sure if its withing the scope of this PR.

Old values in new game: Screenshot (34) Screenshot (36) Screenshot (37) Screenshot (38)

originalfoo commented 2 years ago

urg, 1 sec, will send PR to fix

originalfoo commented 2 years ago

buses may ignore lane arrows used to be off by default

Yeah, that was causing constant trickle of support so it was changed in this PR.

Can change it back to off by default if desired. @krzychu124 what do you think?