This PR fixes that by making the serialized value conistent with how all other options work (not inverted), whilst handling legacy value (inverted) if necessary.
It's based in part on new Version field that @kianzarrin put in PR #1211 (note: if merging prior to that PR, Kian would need to change version in his PR to 2).
Also fixes some trivial analyzer warnings I noticed.
I'm not sure why I didn't notice it but.... if we are starting "new game", there won't be Configuration data so public static int Version => _configuration.Version; will throw null ref exception
For some reason the value of
Options.disableDespawning
was historically inverted during de/serialization.This PR fixes that by making the serialized value conistent with how all other options work (not inverted), whilst handling legacy value (inverted) if necessary.
It's based in part on new
Version
field that @kianzarrin put in PR #1211 (note: if merging prior to that PR, Kian would need to change version in his PR to2
).Also fixes some trivial analyzer warnings I noticed.