SerializableUIOptionBase should contain value/default-values

CitiesSkylinesMods / TMPE

Cities: Skylines Traffic Manager: President Edition

https://steamcommunity.com/sharedfiles/filedetails/?id=1637663252

MIT License

574 stars 85 forks source link

SerializableUIOptionBase should contain value/default-values #1508

Open kianzarrin opened 2 years ago

kianzarrin commented 2 years ago

currently the values are stored in Options.cs and default values are in the legacy code that loads data. We need a central place to store values/default values. it is better to be all in one place. I think we should put them all in SerializableUIOptionBase.

related: #1372 says that all fields of this type should also be moved into one place.

kianzarrin commented 2 years ago

@aubergine10 do you agree with this?

originalfoo commented 2 years ago

I think it depends on outcome of discussions in https://github.com/CitiesSkylinesMods/TMPE/issues/1372

kianzarrin commented 2 years ago

Performance wise virtual property call cannot be optimised. Maybe a non virtual getter might not be a bad idea.