Closed kvakvs closed 2 years ago
I am a Chinese speaker. Is this theme for Mainland China (and may have themes for other parts of China) ? If yes, you may leave the Chinese characters on the signs, they are good for Mainland China style. If this a theme for a generalised Chinese style, as you wrote "not connected to Chinese language in the UI", the Chinese characters should be removed. I find them on "-Taxi.png" "-Emergency.png", ~"PriorityStop.png"~, "PriorityYield.png" and "China.svg".
I did a search for signs of different Chinese styles.
I do not plan to do themes for dialects right now. The selected themes were made by popularity on Steam from top to bottom.
Although it is probably possible to make a theme to "patch" other theme and replace a couple signs only.
P.S. Adding a second theme "China Generic" that will not have text on signs, only Stop 停.
@kvakvs CI borked due to something in OptionsManager
: The modifier 'internal' is not valid for this item
The original vehicle restriction icons are still in TLM\Resources
... suggestion:
TLM\Resources\SignThemes\Fallback
in to TLM\Resources\SignThemes\Kmph_China_Generic
TLM\Resources
to TLM\Resources\SignThemes\Fallback
README.md
in Fallback
folder clarifying what the folder is for?RoadDefaults
folder to DefaultSpeedLimits
or BaseSpeedLimits
? And a README.md
in there too?The original vehicle restriction icons are still in
TLM\Resources
... suggestion:
- Move new Chinese-style vehicle restriction fallback icons from
TLM\Resources\SignThemes\Fallback
in toTLM\Resources\SignThemes\Kmph_China_Generic
- Move original vehicle restriction icons (which users are familiar with) from
TLM\Resources
toTLM\Resources\SignThemes\Fallback
- Add a
README.md
inFallback
folder clarifying what the folder is for?- Rename
RoadDefaults
folder toDefaultSpeedLimits
orBaseSpeedLimits
? And aREADME.md
in there too?
Fallback does not and never contained Chinese signs, but i replaced old vehicle restrictions with similar style blue signs. Chinese signs have Chinese style vehicle silhouettes and some have chinese text on them, Fallback doesn't have that
Original vehicle restriction icons are meant to go, we do not have high resolution source for them, too. But i am quite happy to give the allow icons green border instead of blue circle, making them very similar to previous signs. But green signs do not exist, blue signs are at least remotely realistic.
Adding README to Fallback and renaming RoadDefaults, though
Dark green without inner white circle?
Or bright green with white circle and invert icons to black like the original? Why this inversion - i still care that some people have trouble distinguishing red and green, and only navigate by brightness of the lime signs. Having black and white icons for different states should help more.
Only issue I've found so far while testing (not sure if due to this PR or not) is that when I have speed limit tool open, pressing Esc causes game Pause Menu to appear rather than exiting Speed Limit tool.
EDIT: Other TM:PE tools do handle Esc properly, seems to only be Speed Limits tool that's affected.
EDIT: Only just noticed comments above - will respond to those in a bit.
Original vehicle restriction icons are meant to go, we do not have high resolution source for them, too.
I'm fine with most of the changes. However for passenger train I'd prefer to keep original icon (PR #31) as it's much simpler and easier to comprehend at a glance than a passenger carriage. The hi-res source can be obtained from Noun Project: https://thenounproject.com/icon/passenger-188591/
I think the blue background for "vehicle allowed" was better than the green as it has slightly better contrast with the white vehicle icon in foreground. Also, many countries use blue background with white vehicle foreground to indicate when lane is dedicated to certain vehicle type, and while not a direct facsimile of TM:PE vehicle restrictions I think it would still help to keep that style to aid user comprehension of the feature.
Got these, 2 figures i really like better than 1
This looks wildly unusual but at the same time it looks okay
Oh, sorry, I meant blue bg for vehicle restrictions, not junction restrictions.
IMO the junction restrictions original style was better (with the green circle and white bg). I'm starting to wonder if same is true for vehicle restrictions... while the blue bg certainly differentiates, from a gaming perspective it doesn't feel like it conveys "allowed" (I guess your green backgrounds did better job of that)...?
For generic taxi icon (not language specific), would something like this be better? https://thenounproject.com/icon/taxi-1772875/
Got the taxi icon with a suitcase, yours was just a waving man. Might also change some icons to be from that NounProject to simplify the attribution by a single source, but i tried to only get free / CC licensed stuff, did not record all of it.
These are looking awesome.
I tried to only get free / CC licensed stuff, did not record all of it.
Ambulance url: https://thenounproject.com/icon/ambulance-vehicle-4697238/
Couldn't find url of the truck, but found some in similar style to the ambulance:
Some possible alternate icons for service vehicles (recycle = garbage only, maybe we need something more generic):
Just dumping this link for future reference: https://thenounproject.com/browse/collection-icon/transport-and-vehicle-143436/?p=1
Would it be worth standardising cargo + passenger icons across rail, road, and airport?
Passenger would be the 2 people sitting icon from above https://github.com/CitiesSkylinesMods/TMPE/pull/1523#issuecomment-1093641828
Transport-agnostic cargo icon could be something like...
Would it be worth standardising cargo + passenger icons across rail, road, and airport?
Those aren't in the master
yet, no? I don't remember seeing those files in the old textures i have deleted.
I've reused train icons for airplanes since it was obvious that restriction applies for airplanes (shown at taxiways) -> https://github.com/CitiesSkylinesMods/TMPE/blob/master/TLM/TLM/Resources/cargotrain_allowed.png https://github.com/CitiesSkylinesMods/TMPE/blob/master/TLM/TLM/Resources/passengertrain_allowed.png
I believe that @aubergine10 thought about creating new one for specific vehicle type
Yeah, I was thinking that cargo/passenger is common across all network types that can have vehicle restrictions so it might be good for default icons to be same on road/rail/air.
Obviously, country-specifif theme can override if it wants to - eg. most countries have recognisable signs for buses and trucks.
Replaced: Ambulance, Truck, Garbage Truck with Nounproject icons and wrote down the attribution to the authors
I really like the hopper cargo traincar, and i have its origin recorded too. But i can go with replacing cargo train with cargo on hook, so that it could be used in both airport and train track situations. Don't want to add icons for airport roads, that's another PR, is it even merged?
I found some more standard signs. Can be used as a reference. China (Mainland): (Specified in GB 5678-2009) https://en.wikipedia.org/wiki/Road_signs_in_China China (Hong Kong): https://en.wikipedia.org/wiki/Road_signs_in_Hong_Kong China (Macao): (only pictures) https://commons.wikimedia.org/wiki/User:Fry1989/Gallery/Road_Signs/Macau China (Taiwan): (only pictures) https://commons.wikimedia.org/wiki/User:Fry1989/Gallery/Road_Signs/China#Republic_of_China_(Taiwan)
In addition, the Simplified Chinese of taxi is "出租车" instead of "出租車". "出租車" is Traditional Chinese.
I really like the hopper cargo traincar, and i have its origin recorded too. But i can go with replacing cargo train with cargo on hook, so that it could be used in both airport and train track situations
Ok, what about:
The cargo hook icon might be better suited to cargo harbours should we ever add support for ships (would be cool to have something BFS search algorithm for cargo harbours).
The cargo hook icon might be better suited to cargo harbours should we ever add support for ships (would be cool to have something BFS search algorithm for cargo harbours).
You can't use BFS or any segment iterating algorithm if there are no segments 😂 I don't know the details but I'm pretty sure it works more or less like for airplanes when they leave airplane path while trying to land at airport - they move towards the target that looks more or less like Proportional navigation/homing missile algorithm
Saved hooked cargo on the page side, for future use Reverting cargo train to the cargo hopper icon Forklift i can add the icon to the SVG source, but not export it until it is time.
re: forklift - I found some scissor lift
icons that would perhaps be better suited to airports: https://github.com/CitiesSkylinesMods/TMPE/pull/1458#issuecomment-1099515620
I found some more standard signs. Can be used as a reference. China (Mainland): (Specified in GB 5678-2009)
I used this Wikipedia page to make the first version of the theme. But then some signs in TM:PE do not have standard signs in all countries, so i had to improvise.
https://en.wikipedia.org/wiki/Road_signs_in_China China (Hong Kong): https://en.wikipedia.org/wiki/Road_signs_in_Hong_Kong China (Macao): (only pictures) https://commons.wikimedia.org/wiki/User:Fry1989/Gallery/Road_Signs/Macau China (Taiwan): (only pictures) https://commons.wikimedia.org/wiki/User:Fry1989/Gallery/Road_Signs/China#Republic_of_China_(Taiwan)
Do we need special themes for those territories? I was choosing themes based on potential count of players.
In addition, the Simplified Chinese of taxi is "出租车" instead of "出租車". "出租車" is Traditional Chinese.
This moment was unclear, i guess we're doing simplified rather than traditional.
re: forklift - I found some
scissor lift
icons that would perhaps be better suited to airports: #1458 (comment)
Got this for now. It is not exported or not used anywhere, just a proposed icon which vaguely matches our other vehicles by their wheel shape, so that they look nicely together.
But as a cooment on this: I had discussed with @krzychu also Planes, Cyclists and Pedestrian signs for future development (not only in TMPE, but as it will be something to manage in TMPE it would be nice to have same style for them too)... can you create them in same style? @kvakvs
The pictures are stored as SVG (that's a text file in Git), and you can edit using Inkscape (free software). Also I can add more signs no problem.
@kvakvs I assume that white squares instead of some default speed limits for China_generic is a bug, right?
Edit:
NOTE: Speed limit road signs do not query Fallback theme, it is assumed that any current theme would provide all necessary numbered road signs.
From the log
Debug 602.7954460: Resource SignThemes.Kmph_China_Generic.0.png not found (not an error)
//...
Debug 603.1673537: Resource SignThemes.Fallback.0.png not found (not an error)
//...
Info 603.2467477: Road Sign theme changed to Kmph_China_Generic
@kvakvs I assume that white squares instead of some default speed limits for China_generic is a bug, right?
Edit:
NOTE: Speed limit road signs do not query Fallback theme, it is assumed that any current theme would provide all necessary numbered road signs.
From the log
Debug 602.7954460: Resource SignThemes.Kmph_China_Generic.0.png not found (not an error) //... Debug 603.1673537: Resource SignThemes.Fallback.0.png not found (not an error) //... Info 603.2467477: Road Sign theme changed to Kmph_China_Generic
China Generic theme is BASED ON China, and then China is BASED ON Fallback theme, so white squares are a bug, but "loading error" is not a bug, because it would look 1 and 2 levels down in the base themes. Looks like <theme>/0.png
is missing and that i can fix quickly.
Hmm, China (Mainland) works normally, so no idea why generic is not. Other than that no issues, looks good. Will do another test once fixed.
Oh, I found the newly released regulation document (GB 5768.2-2022). So do you need to change the icon according to the regulation document?
GB 5768.2-2022
Wikipedia signs are 2009 (GB 5678-2009.) If you have a link with all road signs, would be great if they had SVG sources like Wikipedia page. But no SVG is ok too. Or we can update it later, when these new signs are installed in many places?
Wikipedia signs are 2009 (GB 5678-2009.)
I have uploaded a pdf of the GB 5678.2-2022, it may be of some help.
I will make a new task for updating signs, or maybe have China mainland and China Mainland 2022 themes, why not.
Renames
RoadSignTheme<s>
renamed toRoadSignThemeManager
and extracted classRoadSignTheme
into a fileRoadDefaults
special theme (green speed limit signs) renamed toSpeedLimitDefaults
Changes
Kmph_China
road signs theme (source in SVG with fonts)Kmph_China_Generic
road signs theme based onKmph_China
and patches few signs by removing glyphs from them. Stop sign remains with a glyph.Fallback
theme which is used for vehicle restrictions, parking and priority signs as a default fallbacknull
if something fails to load.Need help: A chinese speaker to have a look, there are no road signs for Taxi and Emergency services, so i have translated them myself.(thanks to@lokpro
)