CitiesSkylinesMods / TMPE

Cities: Skylines Traffic Manager: President Edition
https://steamcommunity.com/sharedfiles/filedetails/?id=1637663252
MIT License
574 stars 85 forks source link

lighweight highway merging rules #1542

Closed kianzarrin closed 2 years ago

kianzarrin commented 2 years ago

fixes #1530 . see issue for details.

ATTENTION: Only applies to highway on-ramps(merging) where lane arithmetic works (incoming= outgoing).

bonus: I also modified optimized the way global options variables are accessed. to speed up value access I cache the delegate. this reduces one if condition to check null.

latest branch build: TMPE.zip

tests:

test condition: according to #1530.

backward compatibility:

krzychu124 commented 2 years ago

Werid behavior:

krzychu124 commented 2 years ago

@kianzarrin did you test this? After reading the code I doubt it does anything when "new highway rules" is enabled and may apply changes to non-highway roads too if somehow works.

kianzarrin commented 2 years ago

@krzychu124 its draft. did you read description?

krzychu124 commented 2 years ago

It wasn't a draft when I was reviewing and testing the code...

image

kianzarrin commented 2 years ago

I did not ask for review on this on the description said this is not ready.

kianzarrin commented 2 years ago

@krzychu124 did you test this? After reading the code I doubt it does anything when "new highway rules" is enabled and may apply changes to non-highway roads too if somehow works. I don't understand why you say that. Except for a typo the code is otherwise fine: image

and does not apply to non-highway either. image

kianzarrin commented 2 years ago

@aubergine10 @krzychu124 I hope you didn't forget about this. I have addressed the issues you raised.

kianzarrin commented 2 years ago

@aubergine10 have your concerns been addressed?

originalfoo commented 2 years ago

@kianzarrin I'll be testing this later today.

kianzarrin commented 2 years ago

@aubergine10 can I merge this? (you have requested changes).