Closed kianzarrin closed 2 years ago
Werid behavior:
OptionsManager.UpdateRoutingManager()
3 times.@kianzarrin did you test this? After reading the code I doubt it does anything when "new highway rules" is enabled and may apply changes to non-highway roads too if somehow works.
@krzychu124 its draft. did you read description?
It wasn't a draft when I was reviewing and testing the code...
I did not ask for review on this on the description said this is not ready.
@krzychu124 did you test this? After reading the code I doubt it does anything when "new highway rules" is enabled and may apply changes to non-highway roads too if somehow works. I don't understand why you say that. Except for a typo the code is otherwise fine:
and does not apply to non-highway either.
@aubergine10 @krzychu124 I hope you didn't forget about this. I have addressed the issues you raised.
@aubergine10 have your concerns been addressed?
@kianzarrin I'll be testing this later today.
@aubergine10 can I merge this? (you have requested changes).
fixes #1530 . see issue for details.
ATTENTION: Only applies to highway on-ramps(merging) where lane arithmetic works (incoming= outgoing).
bonus: I also modified optimized the way global options variables are accessed. to speed up value access I cache the delegate. this reduces one if condition to check null.
latest branch build: TMPE.zip
tests:
test condition: according to #1530.
backward compatibility: