CitiesSkylinesMods / TMPE

Cities: Skylines Traffic Manager: President Edition
https://steamcommunity.com/sharedfiles/filedetails/?id=1637663252
MIT License
574 stars 85 forks source link

Locale key updates #1551

Closed originalfoo closed 2 years ago

originalfoo commented 2 years ago

Note: Testing should be done with a DEBUG build (missing locale string pilcrows aren't shown in TEST/RELEASE builds).

Fixes #1344:

Some additional future work is tracked in #1567

New languages (some translations already introduced in earlier PRs):

List of contributors in this batch of updates:

originalfoo commented 2 years ago

image

krzychu124 commented 2 years ago

I've updated translation scheme files (Vietnamese should be available vi), approved and improved some incorrectly translated strings (mostly Italian 😄 )

krzychu124 commented 2 years ago

Is there are chance about merging it till e.g. this weekend, so we could push it to Test and then release hot-fixed 11.6.5.2 to Stable to move away from the current broken/not switchable state (Test <-> Stable)? Since @kianzarrin working on UI for lane connector to separate tracks from road (or even finished if I see correctly) maybe the version should be 11.6.6.0 instead of current 11.6.5.3? It's just a thought to discuss further since would be nice to speed up development and move forward a little bit faster. Heh, my todo list is constantly growing 😂

Next up we have @Elesbaan70 persistence thingy which could be release along with Airports DLC support - not much left to add there, and I thought about using new persistence for serializing passenger airplane size restrictions as any modification to current serialization solution will break compatibility again and complicate things...

Persistence and Airports DLC improvements as a 11.7.x or maybe even better, as v.12 if we generate more changes? I mean.. persistence change is itself a big change 😅 I'll try to squeeze few priority behavior improvements there too or minor improvements for ParkingAI (I've done few experiments already and results are promising - is slightly better than before, without much effort like e.g.: rewriting the logic) I remember you also started working on overlays so it could nicely fit into "big changes" release.

originalfoo commented 2 years ago

Yup, will try and get this done tomorrow. Sorry for delay, been spending lots of time this week arguing with lawyers about changing my legal name to "State Funded Terrorism" which they seem to have issue with yet they're finding it difficult to explain why without accepting that the entire legal system is complete bullshit.

originalfoo commented 2 years ago

ready for testing

krzychu124 commented 2 years ago

Missing key (we can add later) :/ image

/// Not related to this PR but still something we should fix but can live with it

Slider is not disabled in the main menu image

The same for speed limit themes + checkbox - shows warning that settings cannot be changed in main menu so at least that but both are stored in the global config so they could be changed, just skipped regular update and texture generation (will be generated at load time) image

No vertical scroll at Keybinds tab (does not show up and work for some weird reason 🤷‍♂️ )

IMO it's still good enough to push to Stable, anyways

originalfoo commented 2 years ago

Missing key (we can add later) :/

Yup, tracked in https://github.com/CitiesSkylinesMods/TMPE/issues/1567

Slider is not disabled in the main menu

I think they're disabled but just not 'dimmed'.

The same for speed limit themes + checkbox

Those are acutally global options, although I'm not sure why. Personally I feel it would make more sense to have those as savegame options, but they were already done as global options prior to me and Kian reworking the UI components. We could probably look in to that with the new persistence stuff?

krzychu124 commented 2 years ago

I think they're disabled but just not 'dimmed'.

nope, I see it is reporting changes and enabled the dls checkbox despite it was disabled

originalfoo commented 2 years ago

I think they're disabled but just not 'dimmed'.

nope, I see it is reporting changes and enabled the dls checkbox despite it was disabled

I've added a note about that to #1567