CitiesSkylinesMods / TMPE

Cities: Skylines Traffic Manager: President Edition
https://steamcommunity.com/sharedfiles/filedetails/?id=1637663252
MIT License
569 stars 85 forks source link

Yield/Giveway is not adhered to on master branch #1554

Closed winxuser closed 2 years ago

winxuser commented 2 years ago

Describe the problem

Using Steam stable Traffic Manager, everything works fine with priority signage. With a self compiled version from master branch, all priority/yield is not adhered to, turning on and off give-way does nothing.

This could be an issue from my compiling but i have tried to reinstall VS a couple times with .net framework 4.8 and 3.5 and issue still persists.

Log files

https://drive.google.com/drive/folders/1Fvu2WERDM28w5mUfIZ5otCXF8SJh4I6u?usp=sharing

this folder contains output and tmpe logs from both steam downloaded tmpe and self compiled. if link doesnt work please comment

krzychu124 commented 2 years ago

image

Why do you ignore Incompatibility message??

* (local) TM:PE 11.6.5.2 TEST ! 1637663252 TM:PE 11.6.4.8 STABLE Info 22.2979794: Scan complete: 1 incompatible mod(s) found

winxuser commented 2 years ago

its made no difference, i have unsubscribed from the steam version and its made no difference

krzychu124 commented 2 years ago

Unsubscribe, restart game if unsubscribed from in-game, try again, upload new TMPE.log. It's near impossible that won't work.

winxuser commented 2 years ago

new tpme log added, still had the same issue, just not as bad, i had recompiled it again before this log

krzychu124 commented 2 years ago

What Simulation accuracy value you've set in game? Is it the same? Test Very High, anything lower will result in lower accuracy (obviously) so more vehicles may ignore the sign (may not see other vehicles approaching the intersection)

Edit: log looks ok now no issues (besides reset of xml loading because of switch from Stable version).

winxuser commented 2 years ago

set on very high, aggression is on strict, cars coming up to round about still try to enter blocked junction, even though that policy is turned off and giveway sign added

krzychu124 commented 2 years ago

Could you record short clip showing the problem?

winxuser commented 2 years ago

https://user-images.githubusercontent.com/2645165/166123556-13753857-1cc1-43e3-87da-0a49eb5b879c.mp4

thats only a small clip, but if i was to record longer you would be able to see more of it

krzychu124 commented 2 years ago

That behaviour you see (car entering roundabout if should yield) is pretty normal considering all possible options in those condition. The main problem here is congested roundabout which forces vehicles with priority to stop. Yielding vehicle is allowed to enter junction if:

I suggest enabling enter blocked junction inside of roundabout so vehicle with priority won't stop before intersection.

The code for priority behavior was not touched in past year or so, it's exactly the same as in Stable version (yet). I'm working on accuracy improvements to eliminate such situations. -> https://github.com/CitiesSkylinesMods/TMPE/issues/1229#issuecomment-1030912846