search

CitiesSkylinesMods / TMPE

Cities: Skylines Traffic Manager: President Edition
https://steamcommunity.com/sharedfiles/filedetails/?id=1637663252
MIT License
569 stars 85 forks source link

Bigger impact of road condition should not affect highway roads #1569

Open krzychu124 opened 2 years ago

krzychu124 commented 2 years ago

Describe the problem

Highways cannot be maintained so their condition value is always the lowest and currently when the option is enabled it will drop the speed limit for vehicles to min value (-25%).

Steps to reproduce

  1. Snowfall DLC required
  2. Enable the option
  3. Check current vehicle speed at highways, dry road (without Individual Driving Styles), use debug Vehicle overlay.
  4. Vehicles will move at 75% of speed limit or 80km/h if the limit is higher than 110km/h and those roads cannot be maintained by road maintenance vehicle so vehicles will never reach the selected speed limit.
originalfoo commented 2 years ago

Highways cannot be maintained

Are you sure?

I build service stations along my main highway route, and the maint overlay shows the highway as green; there's always a steady stream of maint vans driving along it.

Not sure if the same is true for snow as I never play snowfall maps, but for maintenance I'm almost certain that highways are getting maintained.

I'll do some testing in-game just to double check.

krzychu124 commented 2 years ago

See tab Road Condition not the first one, Coverage

I've checked the code. Transfer offers for road maintenance are sent only from roads with info.m_highwayRules == false You can also check m_condition - it's always zero. The only thing which can increase road condition (by accident) is when you build road network that maintenance vehicle are forced to use highway, but like I said, roads itself don't send requests for maintenance so these going outside the city broders between outside connections will have -25% speed limit.

originalfoo commented 2 years ago

The only thing which can increase road condition (by accident) is when you build road network that maintenance vehicle are forced to use highway

Ah, this is essentially what I've done - all my highway maint buildings are in motorway service stations so they have to use motorway (highway) to get to wherever they want to go.

Is the same kind of issue happening for snow ploughs? Winter biome has even more severe speed nerfs because it's combined snow (wetness) and road condition: https://github.com/CitiesSkylinesMods/TMPE/wiki/Road-Conditions

krzychu124 commented 2 years ago

yeah, it looks like it's similar problem - road requires m_accumulateSnow enabled to trigger request for snow ploughs. I haven't tested yet though