CitiesSkylinesMods / TMPE

Cities: Skylines Traffic Manager: President Edition
https://steamcommunity.com/sharedfiles/filedetails/?id=1637663252
MIT License
569 stars 85 forks source link

Buggy lane routing on complex intersections #1592

Open Elesbaan70 opened 2 years ago

Elesbaan70 commented 2 years ago

When there are multiple outgoing segments in the same direction, RoutingManager doesn't know what to do with it.

Note how in these examples, both left-turn lanes are routed to both outgoing lanes.

image image

kianzarrin commented 2 years ago

I am loving the routing detector tool. how did we live so far without it?!

Elesbaan70 commented 2 years ago

This overlaps some of the lane routing needs for displaced lanes, so I'll fix it at the same time.

kianzarrin commented 2 years ago

I think its better to fix separately. divide the work into smaller pieces to avoid a large PR that is hard to manage.

Elesbaan70 commented 2 years ago

Actually, the lane routing logic for lane groups will inherently resolve this, since each outgoing segment's lanes will be treated as a group.

And yes, it will be a big PR, but mostly limited to one class. The size and scope of the lane routing changes is what made me finally decide to make lane grouping an epic.

kianzarrin commented 2 years ago

i hope there is not too many merge conflicts with my PRs

kianzarrin commented 2 years ago

there is a all-kian branch that includes all those changes in one branch.

Elesbaan70 commented 2 years ago

If you're talking about your RoutingManager work, I will be writing completely new code, so there shouldn't be many conflicts. See #1593.