CitiesSkylinesMods / TMPE

Cities: Skylines Traffic Manager: President Edition
https://steamcommunity.com/sharedfiles/filedetails/?id=1637663252
MIT License
569 stars 85 forks source link

incorporate crazy tourist fix #1595

Closed kianzarrin closed 2 years ago

kianzarrin commented 2 years ago

This mod is 2 simple patches only. we should and easily can bring it to TMPE: https://steamcommunity.com/sharedfiles/filedetails/?id=1759269367 https://github.com/chronofanz/CrazyTouristFix/blob/3132af53f4aa30e45302cc1a3a8166a4f37cd8b4/CrazyTouristFixMod.cs#L58

EDIT: I need to run some tests though to prove its needed and works.

krzychu124 commented 2 years ago

It describes the issue occurs for roads without sidewalks, but... default highway road neither has a sidewalk 🤷‍♂️ It may not be needed by looking at the code, I think 🤔 See #1543

kianzarrin commented 2 years ago

It describes the issue occurs for roads without sidewalks, but... default highway road neither has a sidewalk

is there a contradiction in the statement above?

I have seen that ppl spawn at highway outside connections at jump on a vehicle IIRC.

kianzarrin commented 2 years ago

In any case I do need to run some tests.

krzychu124 commented 2 years ago

I have seen that ppl spawn at highway outside connections at jump on a vehicle IIRC.

My point was that sidewalk is not required for outside connection roads to work correctly so saying that missing sidewalk could cause issues is a bit weird IMO. I also need to run some tests.

kianzarrin commented 2 years ago

@krzychu124 did you read the description completely? he is aware that this problem does not happen with one-way highways that don't have sidewalk.

This behavior also happens at ALL outside connections. Most outside connections are one way out, however, and also these outside connections have no sidewalk either ... Path Manager FAILS (because the road segment is one-way or there's no sidewalk or whatever), and then the citizen then goes away.

kianzarrin commented 2 years ago

reproduced problem: image

kianzarrin commented 2 years ago

This is with the crazy tourist fix mod enabled: image The mod does not work

kianzarrin commented 2 years ago

since the original mod does not fix the problem I close this.