CitiesSkylinesMods / TMPE

Cities: Skylines Traffic Manager: President Edition
https://steamcommunity.com/sharedfiles/filedetails/?id=1637663252
MIT License
569 stars 85 forks source link

no lane arrows => no lane routings. #1601

Closed kianzarrin closed 2 years ago

kianzarrin commented 2 years ago

phase 1 of #1213

At junctions if lane has no arrows, it will have no lane transitions (except for relaxed transitions for SOS vehicles).

applies to JUNCTIONS ONLY!!!!

in the next phase I use the lane connector tool so that we can remove lane transitions from track lanes too.

kianzarrin commented 2 years ago

works image

Elesbaan70 commented 2 years ago

In this example, how is this industrial zone impacted? I'm assuming vehicles can't use the right lane because it has no outbound connection. Does this mean they'll connect from the middle lane? Will connections be possible at all? image

kianzarrin commented 2 years ago

@Elesbaan70 I haven't hard-coded any names/symbols in this PR. That would be for the next phase where I will allow user to make lane to not go anywhere using lane connector tool.

So what we call it is only a matter of release notes. I renamed the PR to avoid implying any name.

krzychu124 commented 2 years ago

I'm not sure if it's a good idea. IMO it's a breaking change. Users for the past years could notice (or knew) that "no arrow" does not break pathfinding and this change may cause ton of issues. Good luck with searching for no arrows in the whole city to fix pathfinding issues which never was a problem before - similar case to NC issue with too big nodes but this one will much harder to spot or even impossible without some automated tools. I've seen a lot of users remove lane arrow props which immediately makes it near impossible to work with the feature - no way to find where you applied it and where not.

Second thing is how we are going to inform users it works like this or that or even that is possible to do plus what are implications of the change?

kianzarrin commented 2 years ago

which never was a problem before

right now no arrow is like forward. so if there is no forward segment it acts as dead end.

I can imagine some ppl removed lane arrows to hide them like NC used to do. this would cause some trouble. I will try to do this using lane connections only then.