CitiesSkylinesMods / TMPE

Cities: Skylines Traffic Manager: President Edition
https://steamcommunity.com/sharedfiles/filedetails/?id=1637663252
MIT License
571 stars 85 forks source link

Dead end connection #1613

Closed kianzarrin closed 2 years ago

kianzarrin commented 2 years ago

fixes #1213: Connecting a lane to itself creates dead end

TMPE.zip

it looks like this: image Note: as it was the case already: if a lane cannot have a possible target, then laneEnd node maker will not be displayed.

data base:

lane arrows:

when user hovers over same lane :

kvakvs commented 2 years ago

Tested and i love it. The mouse cursor on loop lane does not change to (+)

kianzarrin commented 2 years ago

The mouse cursor on loop lane does not change to (+)

its intentional. should it change to + ? Creating dead end removes all existing connections.

kvakvs commented 2 years ago

The mouse cursor on loop lane does not change to (+)

its intentional. should it change to + ? Creating dead end removes all existing connections.

Maybe use some road sign like πŸš«β›” (easy to confuse with minus) or ❌or something

kianzarrin commented 2 years ago

@kvakvs Maybe use some road sign like πŸš«β›” (easy to confuse with minus) or ❌or something

I think there is no need for mouse sign in here. it only makes things more confusing.

kvakvs commented 2 years ago

dead_end dead_end

krzychu124 commented 2 years ago

@kianzarrin dead end icon is not visible if you close tool and open again.

kianzarrin commented 2 years ago

Code looks ok, I hadn't got a chance to test it in game yet.

should I wait?

krzychu124 commented 2 years ago

Yeah, you can wait, I'll do a quick test later today. Do you have any other plans with this feature or something else?

kianzarrin commented 2 years ago

nope this is the last one in the series of the lane connection EPIC issue #1479. There are also few optional issues over there about minor ascetics improvements but I can't fix them.

kianzarrin commented 2 years ago

OK I reset all lane arrow for node regardless of whether or not it had lane connection.