CitiesSkylinesMods / TMPE

Cities: Skylines Traffic Manager: President Edition
https://steamcommunity.com/sharedfiles/filedetails/?id=1637663252
MIT License
565 stars 85 forks source link

Lane arrows when ban private cars on bus lanes is enabled #1656

Open sidboy55555 opened 1 year ago

sidboy55555 commented 1 year ago

When having "Ban private cars and trucks on bus lanes" enabled, the lane arrows of the roads don't change, and so cars on the normal lane won't be able to turn right, unless you manually change the arrows on the road.

Maybe make an setting that takes it in account when creating a road when having this enabled?

krzychu124 commented 1 year ago

@kianzarrin what do you think about this suggestion?

kianzarrin commented 1 year ago

we need to import ILC2 mod into TMPE with support for TMPE features. if memory serves I think the dedicated turning lane policy takes "Ban private cars and trucks on bus lanes" into consideration.

kianzarrin commented 1 year ago

I just don't like the fact that we have to update all lane arrows when such options are enabled. it slows down loading time. maybe if TMPE was loaded earlier when simulation data is ready could solve this problem?

krzychu124 commented 1 year ago

I think that's the way how it should be done - on load apply settings without requesting an update, so other mods will see our changes already and if they change something they can trigger update and our code will run if necessary. With regards to the OP issue we don't update arrows which can cause pathfinding problems like mentioned and I don't think we could avoid mass update in that case (although should be limited only to segments with bus lane)

ZzZombo commented 1 year ago

image image Still an issue. The first image shows how the arrows are allocated w/o dedicated turning lanes. The second is after I enabled them. Note that it still fails to correctly arrange them all, namely the bus lane can't turn left as is. Interestingly the opposite direction doesn't have this problem.

krzychu124 commented 1 year ago

Still an issue. The first image shows how the arrows are allocated w/o dedicated turning lanes. The second is after I enabled them. Note that it still fails to correctly arrange them all, namely the bus lane can't turn left as is. Interestingly the opposite direction doesn't have this problem.

Have you tested it in-game (new game or loaded savegame)? Things in the Editor are not behaving the same as in normal game :/

ZzZombo commented 1 year ago

I did observe this first outside the editor.

side777 commented 1 year ago

I have done some tests with vanilla roads and custom roads (build with road builder and from the workshop). Problem is, that road builder creates roads with banned cars on bus lanes by default. Also some workshop roads do this. So even if the option to ban cars is disabled in TM:PE the dedicated turning lane option will break traffic with those custom roads. Interestingly the vanilla game is allowing dedicated bus lanes on custom roads to take all directions - while the car lanes may or may not get a turning lane depending on the number of lanes of the destination road.

Vanilla roads and custom road with dedicated turning lanes OFF:

Screenshot 18 (Note that I turned off the all direction arrow prop on the bus lane but the lane gets all directions, I double checked.)

And dedicated turning lanes ON:

Screenshot 19

One solution would be the check if a lane actually is allowing cars. This could be because of a custom road, the ban cars option or manually banned cars on that lane. So this would solve all possible cases and not only the case of enabled ban cars option.

In my tests ILC2 is working as intended in all scenarios.