search

CitiesSkylinesMods / TMPE

Cities: Skylines Traffic Manager: President Edition
https://steamcommunity.com/sharedfiles/filedetails/?id=1637663252
MIT License
571 stars 85 forks source link

Better icons for train restrictions #17

Closed originalfoo closed 5 years ago

originalfoo commented 5 years ago

See: https://github.com/VictorPhilipp/Cities-Skylines-Traffic-Manager-President-Edition/issues/127

Should be relatively trivial to implement (just changing some graphics) and would give a big usability improvement.

I can do graphic editing so if you can point me to where the files are I can see if I can do it and submit a PR (or, with my git repo skills, probably just upload new graphics to this issue ticket lol)

krzychu124 commented 5 years ago

I saw that yesterday while I was browsing issues ;) In your repository folder: 'Cities-Skylines-Traffic-Manager-President-Edition/TLM/TLM/Resources/'. There you can find all graphics of mod. You can put updated icons to zip archive and post it even here, no problem :)

originalfoo commented 5 years ago

In addition to the *_allowed.png & *_restricted icons, there are also *_infosign.png icons.

For example: passengertrain_infosign.png.

Are _infosign icons used by TMPE or can I safely ignore them? I suspect they are just original icons that Victor used when creating the allowed/restricted icons...?

FYI, I intend to create extra folders inside TLM/TLM/Resources:

LMK if there are any issues with creating those subfolders.

originalfoo commented 5 years ago

Also, I notice the allowed/restricted icons are 800x800 px -- this seems somewhat excessive, considering their on-screen size? I suspect they could be resized to 400x400 without any negative impacts on image quality in-game.

EDIT: Just realised that when camera is zoomed in very close the icons do get large, hence requiring the 800x800px sprites.

originalfoo commented 5 years ago

Sent PR with updated icons. lmk what you think. :)

krzychu124 commented 5 years ago

I have no issues with those folders, I can easily exclude them while building new version.

Regarding to *_infosign.png icons, unfortunately you can't ignore them because they are used while you're creating a complex Timed Traffic lights e.g. on road segment with monorail junction and some others IIRC, and these signs have a bit different shape as you can see 😉

originalfoo commented 5 years ago

Ah, in that case I'll need to update the train _infosign icons. Will do that tomorrow and send over a PR.