CitiesSkylinesMods / TMPE

Cities: Skylines Traffic Manager: President Edition
https://steamcommunity.com/sharedfiles/filedetails/?id=1637663252
MIT License
575 stars 85 forks source link

Timed traffic lights - warn if segments to short #302

Open originalfoo opened 5 years ago

originalfoo commented 5 years ago

When there are very short road segments near timed traffic lights, it seems to break the traffic lights.

It would be good if we could warn the user about problematic segments.

I do not know what the segment length threshold should be, but it's possible to reproduce the error in the save supplied in #297

I suspect the segment length issue would also impact things like junction restrictions, but have not confirmed this.

originalfoo commented 5 years ago

Tagging #8

FireController1847 commented 5 years ago

Maybe not entirely only warn, but if there's any way we could add support for shorter segments would probably be a much more superior fix than just warning them. This could allow things like cool interchanges with slip-on and slip-off lanes (like the single-point urban interchange) to work. I will try and remember to provide images later.

originalfoo commented 5 years ago

Agreed, if we could find what's causing the issue and fix it that would be best.

If not, we should find a way to warn users about the issue.

Images of practical use of short segments will be useful to show why a fix is preferable.

Shadertheboi-zz commented 5 years ago

Thank you for the suggestion! For the roads in my country, slip roads are littered at almost every traffic junction:

A typical traffic junction with slip roads for the expressway: https://goo.gl/maps/C4X2wgkMoGHsxFDq5

A typical traffic junction with slips roads: https://goo.gl/maps/YvbEMjugwLs4yotk8

If you noticed, this is the exact same junction that I was trying to mimic but failed to do so due to this bug/error where segments are too close to each other.

s2500111 commented 5 years ago

It would be even better, if there is a possibility to fix the broken behaviour, This error is very frustrating and even happening on segments long enough for like two trucks with trailers.

originalfoo commented 4 years ago

There is a possible fix mentioned in #666 - reduce speed on the short segments.

s2500111 commented 4 years ago

Yeah, found that too, can confirm that lowering the speed limit is working.

originalfoo commented 2 years ago

The Broken Nodes Detector mod has a tool which helps users find segments which are too short.

Maybe we could take that code, and when user selects a node to edit TTL, we can highlight any 'too short' segments attached to the node? Or prevent TTL being used on nodes that have a 'too short' segment?