CitiesSkylinesMods / TMPE

Cities: Skylines Traffic Manager: President Edition
https://steamcommunity.com/sharedfiles/filedetails/?id=1637663252
MIT License
571 stars 85 forks source link

Medians #89

Closed originalfoo closed 2 years ago

originalfoo commented 5 years ago

Ah, medians.

Behold: https://steamcommunity.com/sharedfiles/filedetails/?id=1563428928 52349428-71e92100-2a1e-11e9-9469-dc6c383fa2b0 Title: "Fuckery" (2019)

There are a plethora of median-related issues, I'll be using this thread to categorise them all.

originalfoo commented 5 years ago

Routing across medians

As discovered in #39, bus routes sometimes cross medians. While it's likely the road pictured above is a broken asset, this does merit further investigations.

Also, in #85, it was discovered that trucks can drive across medians on large roads.

And in #86, lagging vehicle repathing caused vehicles to drive over medians when a recently bulldozed road segment was replaced by an new road segment.

originalfoo commented 5 years ago

NetInfo.m_CanCrossLane

This property of roads, as far as I can tell, is supposed to determine whether vehicles can cross on-coming traffic. But it seems to ignore medians.

I think it's something that needs further investigation in relation to medians, especially in relation to non-vehicle lanes, as LazarusMan (NeXT2/MOM dev) discusses here: https://github.com/VictorPhilipp/Cities-Skylines-Traffic-Manager-President-Edition/issues/196

For example, pathfinder ignores the 'planting strip' medians on roads like this:

plant strip

Also, some road assets have implemented solid medians at junctions but the pathfinder (even in vanilla game) ignores them and cars drive over them.

1 2 3

andreharv commented 5 years ago

Hey guys just to let you know things are running kinda slow but they are still running. As I had mentioned on the Discord channel, I am working on a MOM update which will be updated soon (soon hopefully means less than a month). After I get it out, I will be able to work on the NExt update which will finally port over the New Roads for Network Extensions mod that was abandoned and has/is causing a lot of issues for people right now. After I get done with that, I am going to pick up another project I had put on the shelf for a year, outlined HERE. I know that since then a lot of people have come up with roads that do this but this addon will allow for the medians to span between networks as well for most two way roads that are in the mod now. I held off because I did not want to add these if the traffic would not honor the medians. Now that the workshop is saturated with these median through node roads, I will have to find some way to incorporate their techniques. All that to say, I'm still on the case.

andreharv commented 5 years ago

Something else I have been playing with is the idea of an interactive way of determining how a median is drawn through an intersection. This may be an addon feature that would require NExt and TM:PE as that is all that would use it for now...But just as you have the multi-colored draggable lane routing paths through nodes, with the supporting NExt roads, you could have a draggable median mapper. It would function similarly to the lane routing mapper, except it would only have one circle in the middle of the network at the beginning of its node. All supporting roads would have a circle. Once you drag the line, the median will form in the junction and the pathfinding will change to reflect this. If you click on the endpoint of the line, you can either reroute to a different road in the junction or cancel (which would remove the median). Obviously this is a 1 to 1 dragging thing and perhaps the roads would need to be over a certain angle from one another for it to be possible. Upgrading one of the median roads to another supported road would maintain the junction. Just some initial brainstorming.

originalfoo commented 5 years ago

The best way I've seen to toggle medians is have them based on traffic lights at the junction. For example, median is there by default but if traffic lights are added it gets removed.

IMO we should go to CO and ask that base game be updated to handle junction-crossing medians better. Requiring users to use TMPE just to control lane changes on roads that use junction-crossing medians is somewhat overkill for many users.

originalfoo commented 2 years ago

I'm no longer able to reproduce the issue in OP (although my city is LHT and the image in OP was done on a RHT city).

image

image

From left to right (on image above):

Elesbaan70 commented 2 years ago

@aubergine10 I am trying to wrap my mind around the lane configuration that would make the original screenshot in this issue possible. Is it like this? F=forward, B=backward

BBFF BBFF

If so, then the displaced lanes project will resolve it with the newly added requirements on routing.

originalfoo commented 2 years ago

@Elesbaan70 see text under image in https://github.com/CitiesSkylinesMods/TMPE/issues/89#issuecomment-989562534

the asset is here: https://steamcommunity.com/sharedfiles/filedetails/?id=1563428928

I'd suggest using Network Detective to get more specific details. Also note the None lane spanning 2 pedestrian lanes in the middle. And yes, your displaced lanes project will almost certainly resolve that issue.

It might be worth collating related issue ids in your main issue so we can reference them in PR and subsequently the release notes / changelogs.

originalfoo commented 2 years ago

BTW, here's a list of some obscure roads that might be useful for testing: https://github.com/CitiesSkylinesMods/TMPE/wiki/Roads-to-Test

Elesbaan70 commented 2 years ago

the asset is here: https://steamcommunity.com/sharedfiles/filedetails/?id=1563428928

Whoa. That led me to look up Avenida 9 de Julio, and it turns out that is the ultimate test of #1392 and #1528, together. 🤯

image