CitizenLabDotCo / citizenlab

Go Vocal is a digital democracy platform that facilitates community participation and co-creation. Participants can post ideas, contribute to discussions, or choose to vote and prioritize community projects.

https://www.govocal.com

Other

211 stars 34 forks source link

TAN-2792: Turn on no unnecessary condition #9084

Open EdwinKato opened 4 days ago

EdwinKato commented 4 days ago

Changelog

Technical

This updates the ESLint configuration to enforce the @typescript-eslint/no-unnecessary-condition rule as an error. This rule helps identify conditions that are always truthy or falsy based on TypeScript's type analysis, ensuring that our code is more accurate and free of unnecessary checks.

EdwinKato commented 4 days ago

393 errors to work through as of 10th October, 2024

notion-workspace[bot] commented 3 days ago

Turn on no unnecessary condition or add exceptions and comments for them

cl-dev-bot commented 18 minutes ago

	Warnings
:warning:	The branch name contains no Jira issue key (case-sensitive)

	Messages
:book:	Changelog provided 🎉
:book:	Notion issue: TAN-2792
:book:	Run the e2e tests
:book:	Check translation progress

Generated by :no_entry_sign: dangerJS against 593c39ad3e708ff5c3586b550966042d1f2b3582