CitizensDev / Citizens

NPCs for Bukkit
citizensnpcs.co
Other
107 stars 53 forks source link

Citizens 1.1.1 Memory Leak - 187 NPCs #226

Open MadcowD opened 13 years ago

MadcowD commented 13 years ago

Bukkit #: 1185 Citizens#: v1.1.1 NPC Count#:187 Player Count#: 0 Ram w/o Citizens: 4.8% Ram w/ Citizens: 4.8% -> 100% RAM CPU w/o Citizens: 30% CPU w/ Citizens: 30% -> 100%

Ram TOTAL: 16 Gig CPU TOTAL: 4 Core 3.0Ghz

Plugins:

http://dl.dropbox.com/u/38431601/Untitled.png

So here is my ram and CPU usage on start up: http://dl.dropbox.com/u/38431601/Test/Untitled.png And here it is about 30 minutes in (not max): http://dl.dropbox.com/u/38431601/Test/Untitled2.png

It's pretty disturbing to me that this can happen on a server with specs like mine. I presume it might be other plugins registering all the NPCs as players and using up ram for them. However I don't understand why it would continue onward with 0 players online until it maxed out.

It actually might be a heroes incompatibility with the Heroes plugin since I saw NPC's names getting saved multiple times. Thank you anyway.

~Madcow

MadcowD commented 13 years ago

Oh I also seem to be getting a bunch of End of Streams on startup. http://dl.dropbox.com/u/38431601/Test/Endofstream.png Don't seem to be getting them without Citizens.

:#

fullwall commented 13 years ago

The end of streams don't seem to affect anything. Any chance you could run a profiler such as JProfiler to determine specifically where these leaks occur? That'd really help out.

adambratt commented 13 years ago

I am also getting a ton of end of streams and my server is eventually crashing with not enough memory left.

I'm also getting a "too many files" exception from time to time. I haven't targeted this directly to Citizens but I have a strong suspicion these two errors might be related.

I am also running Heroes and I have around 500 NPCs with an i7 3.0ghz and 8GB of ram.

adambratt commented 13 years ago

On another note....MadcowD why the hell are you using IE x.x

adambratt commented 13 years ago

Two more things:

fullwall: how would I go about using jProfiler.

MadCowD: are you sure it's saving them in heroes???? If so that issue needs to be brought up with the Heroes team as it will affect all NPC type plugins that are used with Heroes.

If Heroes is truly seeing them as normal players, let me know and I'll write a temporary fix for us both to use until the Heroes team can actually address the issue.

fullwall commented 13 years ago

@adamjon858 - what happens if you disable Heroes? Does the lag go away? To use jProfiler, you need to download the trial and attach it to your craftbukkit JVM. Then you can see which classes are taking the most memory and can even tell which methods are using the most CPU.

MadcowD commented 13 years ago

@fullwall Same thing happens if I disable heores. Ram is still climbing even with the new RB. jProfiler isn't working out to well so I don't know what to tell you. I'll try messing arround this weekend.

fullwall commented 13 years ago

I guess there must be a leak somewhere... it'd really help if you could get some kind of profiler working (jProbe is a possible alternative, never used it though...) I know it's a big ask :(. Memory leaks are hard for me to track down since I can't run a test server for that long, but still need the profiling data.

Drehverschluss commented 13 years ago

Now we have another weird thing running! Craftbukkit #1240 Citizen 1.1.1 iConomy6

when i am using the 1.1.1 build from Citizens all is working fine but when i am using 1.1.2 the RAM´s runs up?! the only thing on the 1.1.1 build is the End of Streams on startup.(that was Madcow sad)

fullwall commented 13 years ago

You can't use 1.1.1 with #1240. I suggest running the latest dev build with 1.1.2.

Drehverschluss commented 13 years ago

yea i knwo that but the 1.1.1 Citizen.jar exist on a version from your #1240 build

Drehverschluss commented 13 years ago

i can give you the Zipfile of that Build when you want