search

CitizensDev / Citizens2

Citizens - the premier plugin and API for creating server-side NPCs in Minecraft.
https://citizensnpcs.co
Open Software License 3.0
603 stars 317 forks source link

Armorstand Nameplates #1319

Closed Lyesmith closed 6 years ago

Lyesmith commented 7 years ago

Possible bug? Current Minecraft and Citizens2. I used /ex animate n@<NPCNAME> animation:sit to make some NPCs sit. After the nightly server restart, they all now have "Armorstand" nameplates hovering underneath them. I asked in the Discord if there was a way to toggle those off and on, he suggested I report it as a possible bug. If any other info is needed I'll be happy to provide it.

Ouroboros1992 commented 6 years ago

Got this too, seems to add another one after resetting as well so now i've got 2 armor stand nameplates under the npcs.

fullwall commented 6 years ago

Seems like an issue with denizen? @mcmonkey4eva

mcmonkey4eva commented 6 years ago

That command just triggers the PlayerAnimation.SIT animation on the NPC, any issues with armorstands from that are caused by the armor stand generation logic in PlayerAnimationImpl in Citizens2.

It's probably that server restarts don't cause running tasks to cancel? And thus the armor stand NPCs generated don't remove themselves. Might be good to have temporary NPCs placed into a secondary registry or otherwise made to not save themselves...

mcmonkey4eva commented 6 years ago

should be fixed in latest dev build via https://github.com/CitizensDev/Citizens2/commit/e4f059683a3f111e34c35589177c39fe512ecb1b