search

CitizensDev / Citizens2

Citizens - the premier plugin and API for creating server-side NPCs in Minecraft.
https://citizensnpcs.co
Open Software License 3.0
590 stars 313 forks source link

Traversing Nether Portals breaks Navigation #1568

Closed SnoFox closed 4 years ago

SnoFox commented 6 years ago

The output of command /version on my server is: git-Spigot-6b015b4-94b8708 (MC: 1.13.1) (Implementing API version 1.13.1-R0.1-SNAPSHOT) The output of command /version citizens on my server is: 2.0.24-SNAPSHOT (build 1570)

When Citizens NPCs move into a Nether portal, Minecraft will teleport them. After teleport, Citizens is still protecting them, but NMS's AI takes over for movement. Doesn't affect Player NPCs; I've only tested with Ocelots so far.

Citizens configuration file is default; all I did was load the latest build.

Here's an example of my plugin pathing and forcing an NPC to stay in the same world, but fails pathing after going through the netherpotal: https://youtu.be/sXaGTIWXabg Logs: https://gist.github.com/SnoFox/394657ea4f34d0b37e79f069faf9c294#file-2018-09-18-15-log

And another example, using just Citizens commands to create pathing and demonstration of NMS AI taking over: https://youtu.be/b1cLSsSV15c Logs: https://gist.github.com/SnoFox/394657ea4f34d0b37e79f069faf9c294#file-2018-09-18-16-log

SnoFox commented 6 years ago

Workaround for those who don't want their NPCs to teleport: Cancel EntityPortalEvent if it's your entity

fullwall commented 6 years ago

Seems like a difficult problem with entities and changing worlds. I pushed a semi-fix for portals but may need more changes to deal with cross-world teleporting.

mcmonkey4eva commented 6 years ago

@SnoFox is there still trouble on the latest version?

SnoFox commented 5 years ago

Hey @mcmonkey4eva, apologies again for not seeing this for so long. I think I've fixed my GitHub e-mails if you guys need any follow-up.

It appears to still be an issue on git-Spigot-573cdf2-dff66df (MC: 1.13.2) (Implementing API version 1.13.2-R0.1-SNAPSHOT) and Citizens 2.0.24-SNAPSHOT (build 1604), though it seems like the changes in Spigot since I've last worked on this has caused my previous workaround to fail.

mcmonkey4eva commented 4 years ago

Possibly fixed in new builds (at https://ci.citizensnpcs.co/job/Citizens2/ ) by https://github.com/CitizensDev/Citizens2/commit/bbf3f281ebe9eaa0be76086ef566349f8246d57d

Please reply below if it isn't fixed yet.