Players share NPC text chain

[philip-ulrich]

opening issue as requested by fullwall on discord:

- A detailed description of your issue or feature request Using /npc text. Turned off the eavesdrop feature, but now if two people are in range, they get separate pieces of the same convo.

Example: If there are 4 pieces of text (and random is OFF) then each player nearby gets delivered a separate piece at the same time:

• P1 gets messages #1,3
• P2 gets messages #2,4

Whereas P1 and P2 should both be getting 1,2,3,4.

Screenshot: https://imgur.com/a/wlaMOpM

So essentially, the npc seems to think they are the same person, and delivering from the same dialog tp both, on the same tick. Thus making it so that no player standing nearby, gets the whole text. They just get half.

- Link to server log & Citizens config (using e.g. pastebin.com): config.yml: https://pastebin.com/46JMiVYw saves.yml: https://pastebin.com/ixQerW6b server log: https://pastebin.com/HQHF5Vte

The output of command /version on my server is: (PLEASE FILL IN)

16:35:45 INFO: CMI: 8.6.16.3-> 8.6.16.4 16:35:45 INFO: Server version: Paper(234) 1.14.4-R0.1-SNAPSHOT 16:35:45 INFO: Vault version: 1.7.3-b${env.TRAVIS_BUILD_NUMBER}

The output of command /version citizens on my server is: (PLEASE FILL IN) [16:35:51 INFO]: =====[ Citizens v2.0.26-SNAPSHOT (build 1789) ]===== [16:35:51 INFO]: -- Author: fullwall [16:35:51 INFO]: -- Source Code: http://github.com/CitizensDev [16:35:51 INFO]: -- Website: http://www.citizensnpcs.co [16:35:51 INFO]: -- Report an issue: http://github.com/CitizensDev/Citizens2/issues

[mcmonkey4eva]

• Remove (or fix the configuration of) CMI. It's taken over your /version command, which is pretty awful.
• Consider using Denizen for more controllable NPC chatter.
• It's not that the NPC thinks they're the same, it's that the /npc text system is not designed for coherent dialogues, and the non-random talker option just goes in order, without differentiating between players or the passage or time or anything else. There's a single variable tracking where in the list it's at. Refer also to the relevant implementation here: https://github.com/CitizensDev/Citizens2/blob/8c30a785a4d0c361148e629f96f8454c4e6786f5/main/src/main/java/net/citizensnpcs/trait/text/Text.java#L217-L222

It might be possible to add per-player tracking, but... you should probably just use Denizen tbh. This type of thing is one of the basic examples of Denizen usage, that we used to teach everyone on day 1 of installing Denizen.

[philip-ulrich]

Remove (or fix the configuration of) CMI. It's taken over your /version command, which is pretty awful.

Heh... yeah, idk what's up with that.

It's not that the NPC thinks they're the same [...]

Thanks for the additional info on that. Makes sense. Well, it doesn't make sense, but I understand that the current implementation doesn't support it. I was trying to avoid installing another plugin that I'd have to manage version of for something so simple, but alas I shall give in.

NPS 10/10