CitizensDev / Citizens2

Citizens - the premier plugin and API for creating server-side NPCs in Minecraft.
https://citizensnpcs.co
Open Software License 3.0
590 stars 313 forks source link

Add nbt_attributes and script in NPC drops of save file #2064

Closed sentsuetrong closed 4 years ago

sentsuetrong commented 4 years ago

Hello, This is my first issue for feature request so I am using Citizens2, Sentinel, Denizen and I found out that I can't make them drop an item with nbt_attributes and script (script tag is from denizen for events handler thing) I would like to see this in the next feature of Citizens 2

Thanks Suetrong.S (Zen)

The output of command /version on my server is: git-Paper-126 (MC: 1.15.2) The output of command /version citizens on my server is: 2.0.26-SNAPSHOT (build 1844)

fullwall commented 4 years ago

So you're asking for serialising the NBT tag from the item?

mcmonkey4eva commented 4 years ago

Mainly asking about attributes: https://minecraft.gamepedia.com/Attribute but seems to have thrown in a request for generic serialization support too

fullwall commented 4 years ago

I have implemented attribute serialisation

sentsuetrong commented 4 years ago

oh i see, the latest version already have attribute serialisation, then just only script tag from denizen that hasn't been done yet. thanks for the hard working.