search

CitizensDev / Citizens2

Citizens - the premier plugin and API for creating server-side NPCs in Minecraft.
https://citizensnpcs.co
Open Software License 3.0
590 stars 313 forks source link

/npc lookclose doesn't work #2213

Closed Andre601 closed 4 years ago

Andre601 commented 4 years ago

The output of command /version on my server is: 2.0.27-SNAPSHOT (build 2018) The output of command /version citizens on my server is: git-Paper-371 (MC: 1.15.2)

NPCs that have a pose set are no longer able to move using /npc lookclose They will remain in the position you set.

  1. Create a new pose using /npc pose --save <name>
  2. Enable lookclose using /npc lookclose
  3. Enter and leave the NPCs lookclose area.
  4. The NPC won't rotate and look at you.
mcmonkey4eva commented 4 years ago

That's probably https://github.com/CitizensDev/Citizens2/commit/0293ac17dfddb9f34425213dc095aed8b9369027#diff-0742b33e8556f8bd8686b87696a747dfR128

                && (!npc.hasTrait(LookClose.class) || npc.getTrait(LookClose.class).canSeeTarget())) {

A missing ! on the canSeeTarget

Andre601 commented 4 years ago

Works with the latest release.