search

CitizensDev / Citizens2

Citizens - the premier plugin and API for creating server-side NPCs in Minecraft.
https://citizensnpcs.co
Open Software License 3.0
589 stars 313 forks source link

"/NPC Path" Waypoint Markers Stuck #2378

Closed mcmonkey4eva closed 3 years ago

mcmonkey4eva commented 3 years ago

The output of command /version on my server is: This server is running CraftBukkit version git-Spigot-aa47792-6fd677c (MC: 1.16.4) (Implementing API version 1.16.4-R0.1-SNAPSHOT) The output of command /version citizens on my server is: Citizens version 2.0.27-SNAPSHOT (build 2162) (Both latest at time of posting)

This has been reported by a few different users on Discord and elsewhere over the past weeks or so, but thus far nobody's been able to post a clean issue for it.

stuckentities

When making a path with /npc path, these little spinny ball entities things (shulker bullets?) are placed down to mark the points... how they don't disappear when using /npc path again to get rid of them.

When debug-mode set true in the Citizens config.yml, the following output shows:

[16:24:44] [Server thread/INFO]: mcmonkey4eva issued server command: /npc path
[16:24:45] [Server thread/INFO]: [Citizens] Removing respawns of 0 due to SpawnReason.CREATE
[16:24:45] [Server thread/INFO]: [Citizens] Spawned 0 SpawnReason.CREATE
[16:24:47] [Server thread/INFO]: [Citizens] Removing respawns of 1 due to SpawnReason.CREATE
[16:24:47] [Server thread/INFO]: [Citizens] Spawned 1 SpawnReason.CREATE
[16:24:48] [Server thread/INFO]: [Citizens] Removing respawns of 2 due to SpawnReason.CREATE
[16:24:48] [Server thread/INFO]: [Citizens] Spawned 2 SpawnReason.CREATE
[16:24:50] [Server thread/INFO]: mcmonkey4eva issued server command: /npc path
[16:24:50] [Server thread/INFO]: [Citizens] Removing respawns of 0 due to SpawnReason.CREATE
[16:24:50] [Server thread/INFO]: [Citizens] Spawned 0 SpawnReason.CREATE
[16:24:50] [Server thread/INFO]: [Citizens] Removing respawns of 1 due to SpawnReason.CREATE
[16:24:50] [Server thread/INFO]: [Citizens] Spawned 1 SpawnReason.CREATE
[16:24:50] [Server thread/INFO]: [Citizens] Removing respawns of 2 due to SpawnReason.CREATE
[16:24:50] [Server thread/INFO]: [Citizens] Spawned 2 SpawnReason.CREATE
[16:24:50] [Server thread/INFO]: [Citizens] Preventing further respawns of 2 due to DespawnReason.REMOVAL
[16:24:50] [Server thread/INFO]: [Citizens] Despawned 2 DespawnReason.REMOVAL
[16:24:50] [Server thread/INFO]: [Citizens] Preventing further respawns of 1 due to DespawnReason.REMOVAL
[16:24:50] [Server thread/INFO]: [Citizens] Despawned 1 DespawnReason.REMOVAL
[16:24:50] [Server thread/INFO]: [Citizens] Preventing further respawns of 0 due to DespawnReason.REMOVAL
[16:24:50] [Server thread/INFO]: [Citizens] Despawned 0 DespawnReason.REMOVAL

It appears to first create each marker as an NPC while placing them, and then when the editor is closed, it spawns 3 new ones, then attempts to despawn the originals?

Also: using toggle path prior to closing the editor will get rid of the shulker bullets as expected... however, even with the path toggled off, closing the editor will immediately spawn the bullets back in.

mcmonkey4eva commented 3 years ago

Fixed via https://github.com/CitizensDev/Citizens2/commit/ba00c91a30432fa28271c3f56f8b66a84687c0c9 for build starting 2164+ from https://ci.citizensnpcs.co/job/Citizens2/