CitizensDev / Citizens2

Citizens - the premier plugin and API for creating server-side NPCs in Minecraft.
https://citizensnpcs.co
Open Software License 3.0
589 stars 313 forks source link

Suggestion about performing a blocking I/O operation on the main thread #2861

Closed FunkyNico closed 2 years ago

FunkyNico commented 2 years ago

I confirm that I have ...

Description

I found this suggestion from another spigot plugin called Lagmonitor : Make stop the plugin from doing a blocking I/O operation on the main thread because this could affect the server performance, the thread pauses until it gets the response. Such operations should be performed asynchronous from the main thread. Besides gameplay performance it could also improve startup time.

Citizens2 Version: 2.0.30-b2666 / Server: Purpur-1762 (MC: 1.19.2) (Implementing API version 1.19.2-R0.1-SNAPSHOT) (Git: 39e30d6 on HEAD).

Log: https://logs.apexminecrafthosting.com/4dRrBrf

Thanks =D.

Code Example

No response

mcmonkey4eva commented 2 years ago

Please don't make technical issue posts about technical topics you don't understand.

You just requested that Citizens should not load config files while your server is starting.

Automated tools like that can generate hints for things devs might want to look at, not confirm they're correct.