CitizensDev / Citizens2

Citizens - the premier plugin and API for creating server-side NPCs in Minecraft.
https://citizensnpcs.co
Open Software License 3.0
592 stars 315 forks source link

Slow motion, and head pitch issues #3054

Open kangarko opened 1 year ago

kangarko commented 1 year ago

/version output

This server is running Paper version git-Paper-194 (MC: 1.20.1) (Implementing API version 1.20.1-R0.1-SNAPSHOT) (Git: 1b1c230)
You are running the latest version
Previous version: git-Paper-171 (MC: 1.20.1)

/version Citizens output

2.0.32-SNAPSHOT (build 3205)

Log file

N/A

config.yml

https://paste.denizenscript.com/View/115396

saves.yml

https://paste.denizenscript.com/View/115397

Profiler report

No response

Description

Hey there! I'd like to request help with 3 small things. We spent hours trying to figure it hour so I apology if I am missing something, but I decided to reach out because I am not so familiar/confident with Citizens codebase even after looking through the docs.

See the code below.

1st issue: Movement is too slow unless I explicitly force it through baseSpeed:

Desc: That appears to cause some conflicts such as with speed potions and does not properly work on 1.8.8. Demo: https://www.loom.com/share/4022820fc5a3405cb262324cb77d1e65 Code:

gps.getLocalParameters().speedModifier(1F);
gps.getLocalParameters().speed(1F);
gps.getLocalParameters().baseSpeed(6F);

2nd issue: The bosses head pitch seem to be look up or down, it happens when they are targeting or wandering around

Desc: Please see https://github.com/kangarko/Boss/issues/1210 Demo: See the above link Code: I have no idea where in my code this could be happening, I apology. I cannot reproduce on the above versions sadly but the user is clearly having something going on.

3rd issue:

Desc: Thanks for helping me with this last time, I tried using "gps.getLocalParameters().distanceMargin(0.5).pathDistanceMargin(0.5);" but it still appears to be going on. Demo: https://github.com/kangarko/Boss/issues/1195 (the bottom) Code: gps.getLocalParameters().distanceMargin(0.5).pathDistanceMargin(0.5);

Full code:

Here is my integration code: https://paste.denizenscript.com/View/115398

Thanks, Matej

fullwall commented 1 year ago

Re issue 1 - you should be setting speedModifier rather than all 3 of the parameters Re issue 2 - I can't load the video linked there. Re issue 3 - can you restate the issue? I can't quite understand and again the video doesn't load

If you use discord that would be appreciated since this issues page is checked less frequently

kangarko commented 1 year ago

Thanks. I prefer talking here since I am not available as often as I wished. I'm fine with the delay.

1 - Why do I need to set it in the first place? Should not Citizens set it appropriately per entity type without me having to set it manually?

2 - I apologize, I have reuploaded it from the user on your behalf: https://ufile.io/u89yij12

3 - I reuploaded the 14sec clip here: https://ufile.io/c0hephiz Basically the user complains that his Boss (your custom NPC) stops following the player, as seen in the clip.

fullwall commented 1 year ago
  1. I can't replicate this, the default speed is ~0.3 for me and players move normally I can't download the clips. Can you upload them to github or put them somewhere usable
kangarko commented 1 year ago

That's really odd since the user did originally upload to Github. I downloaded it on his behalf and reuploaded to youtube:

Screenshot 2023-10-04 at 07 32 58

https://www.youtube.com/watch?v=H8ootePyPD8

and

https://www.youtube.com/watch?v=LL1UT_Hz0YE