CitizensDev / Citizens2

Citizens - the premier plugin and API for creating server-side NPCs in Minecraft.
https://citizensnpcs.co
Open Software License 3.0
589 stars 313 forks source link

Add back 1.12.2 #3078

Closed TheJoshue closed 10 months ago

TheJoshue commented 10 months ago

I confirm that I have ...

Description

  1. 1.12.2 is still used by servers which want to consume lower bandwidth per player and evade using 1.8
  2. 1.12.2 is widely used for hub servers still
  3. i guess using older builds, but i am not sure if they will work well when 1.20.4 client join on 1.12.2 server (using viaversion)

Code Example

No response

TheJoshue commented 10 months ago

i suggest you rather drop all versions except:

so following 1.8.8/1.12.2/1.16.5 because they're most optimized/stable ones and then 1 latest version (currently 1.20.4) and also 1 previous from latest (1.19.4)

And i think this should be ideal, why would anyone use 1.18 now or any inbetween version... no point literally

and of course when 1.21 comes out, announcing that 1.19.4 will be dropped because 1.21 will be latest and 1 previous from latest will become 1.20.4 ... etc

TheJoshue commented 10 months ago

I created PR, i hope you'll take it https://github.com/CitizensDev/Citizens2/pull/3079

mcmonkey4eva commented 10 months ago

Minecraft 1.12 was released a full 6 years ago, it makes no sense to run a version that old.

Some people don't update immediately to the latest version for their own reasons, or because some other plugins are slow about updating so they're stuck behind, or etc. which is why most plugins including ours try to support at least a few recent versions back.

Running a version from 6+ years ago is ridiculous. Supporting it in any form (developmental support, or interpersonal support ie dealing with issues/questions/etc about it) is a significant burden that we have no reason to undertake. Supporting recent versions (eg 1.19, 1.18) is very very simple to do, which is why they're kept.

1.12 has only a small percentage of users, lower than even the collection of clickspam pvp users who angrily refuse to update past 1.8.

Also, modern server technology (Paper's advancements, minecraft's own tick-view-distance controls recently added based on papers past work, chunk paletting, ...) make modern server versions like 1.20 some of the most efficient (when well configured) on bandwidth/cpu/etc, so that's not an excuse.

TheJoshue commented 8 months ago

I really need 1.12.2...