CitizensDev / Citizens2

Citizens - the premier plugin and API for creating server-side NPCs in Minecraft.
https://citizensnpcs.co
Open Software License 3.0
603 stars 317 forks source link

Armorstands / NPC's dissapearing until /citizens reload #803

Closed Sikatsu closed 8 years ago

Sikatsu commented 8 years ago

Sometimes the armorstands and NPC's, both from Citizens2. are vanishing.

For a referance: http://prntscr.com/b7haw9

These npc's were vanished until I used /citizens reload

Plugins:

23.05 17:45:42 [Server] INFO Plugins (49): BlockParticles, PlaceholderAPI, PlugMan, SuperTrails, FlashLight, DeathMessages, CratesPlus, CoreProtect, AsyncWorldEditInjector, dynmap, VoteRoulette, AnimatedNames, ChatControl, WorldBorder, Votifier, ProtocolLib, AdvancedPortals, AsyncWorldEdit, PermissionsEx, mcMMO, MoneyMobs, HolographicDisplays, WorldEdit, React, MobArena, LWC, WorldGuard, ArmorStandEditor, PetBlocks, ScratchCards, CustomNoteBlock, Vault, BattlePets, ZHorse, AuctionHouse, BuyHead, MyCommand, Essentials, Stickers, LiteBans, Citizens, CustomGUI, EnjinMinecraftPlugin, EssentialsGeoIP, CommandNPC, EssentialsSpawn, PremiumVanish, CompatNoCheatPlus, NoCheatPlus

Spigot version:

1.9.4

Citizens version:

2.0.18-SNAPSHOT build 1367

Sikatsu commented 8 years ago

Any news regarding this issue? @mcmonkey4eva

I know /citizens reload is simple to do, but it's quite annoying if theres no staff online.

LoXR commented 8 years ago

Yes! I have this problem so much aswell. I'm using the addon plugin CarlTheCreeper for player rewards, and I'm having to do /citizens reload everytime after a certain time to get him back.

fullwall commented 8 years ago

Working on it, it may be a plugin compat issue though

Sikatsu commented 8 years ago

I can't imagine which it might be, I don't have any special plugins or so. I removed PetBlocks and NoCheatPlus is replaced with AAC in the meanwhile.

fullwall commented 8 years ago

Can you try and get some debug-mode: true output when this happens?

Sikatsu commented 8 years ago

That's very hard to do so.

Will that spam me or the console?

Most of the times I get a discord message saying ''the shops are gone again..''

fullwall commented 8 years ago

It will give a little bit of spam to the console... I can add a setting to write it to a file or something.

Sikatsu commented 8 years ago

That would be awesome. Then I can just turn it on, and as soon as I see that the npc's are gone I sent you the file. However, even then, I'm not sure if I can give you a close time.

fullwall commented 8 years ago

I added a new setting in the latest build.

Sikatsu commented 8 years ago

Perfect, as soon as they dissapear I'll send you the file!

LoXR commented 8 years ago

Hmmm for me personally, i'm running Spigot 1.8.8. So I dont think I can run this for myself.

Sikatsu commented 8 years ago

When I have debug-mode: true it spams the console, how to get it so it will write to the log?

mcmonkey4eva commented 8 years ago

Set the new config option general.debug-file to a valid file name to send debug logs to.

Sikatsu commented 8 years ago

I tried this: http://prntscr.com/bdcy7c with and without the "

And also log.txt, but that doesn't seem to work.

Sikatsu commented 8 years ago

They still keep dissapearing but I don't get the debug to work..

fullwall commented 8 years ago

Try setting it to plugins/Citizens/log.txt

Sikatsu commented 8 years ago

Thanks, works now. When it dissapears again I'll send you the file.

Sikatsu commented 8 years ago

It's really hard because they always dissapear when i'm not online. However, a player just messaged me on skype that the shop villagers are gone again. So heres the file, the villagers for sure dissapeared within this log file. But it might be very large. Hope it helps :/

I noticed I forgot to mention which NPC's I actually mean. So far, I noticed it occurs on ''Armorstands'' and ''Villagers''. When those dissapear, the normal player NPC's are always still there. Worth mentioning, I don't have any plugin removing entities like armorstands or villagers.

/citizens reload always spawns them back.

No armorstands: http://prntscr.com/beni49

No villagers: http://prntscr.com/bengvc

There are, however, the player npc's: http://prntscr.com/beni8z

Log.txt: https://www.dropbox.com/s/j0h78kjzaj6gy8j/log.txt?dl=0

@fullwall

mcmonkey4eva commented 8 years ago

It looks like at timestamp 2016-06-10 05:00:00 everything got reloaded. Could be related?

Sikatsu commented 8 years ago

Thats because the server gets restarted at midnight. However, the npc's dissapear during the day.

fullwall commented 8 years ago

What IDs are the NPCs who disappeared? Also I may have to get you a new build as I didn't realise that you reloaded so often.

Sikatsu commented 8 years ago

When using /npc select and teleporting to that ID, it teleports me to the NPC"s which are dissapeared. So it seems, most, if not all ID's from the log are dissapearing.

I only restart my server at midnight, and I use /citizens reload everytime the NPC's are dissapeared.

At the moment of writing, the npc's are once again gone :s

fullwall commented 8 years ago

The log is cut off a bit that's all. Are any of the NPCs in that log disappearing e.g. 642, 666?

Sikatsu commented 8 years ago

Cut off? It's the full log I downloaded from the folder o.O

As said earlier, yes those npc's are dissapearing. (Well 666 is not)

As far as I know, these are the dissapearing ID's:

401 445 510 511 512 514 516 525 627 634 638 639 640 641 642 643 660

Edit: On the moment of writing they are gone again.

fullwall commented 8 years ago

I have made an update based on that info: can you please test the latest build? Also it'd be nice to get a fresh log as well if the error still occurs.

Sikatsu commented 8 years ago

I will test the latest build. It works on both 1.9 and 1.10?

fullwall commented 8 years ago

No... just 1.10 unfortunately. I can get you a 1.9 build but it will have to wait a day.

Sikatsu commented 8 years ago

In that case I can't test until i'm running 1.10 (Monday or Tuesday)

Will mention you here when tested then. ^^

Sikatsu commented 8 years ago

@fullwall

Alright, just tested it.

It seems to work with villager npc's, but not with armorstand npc's.

ID's: 638 639 640 641 642 643

If for some reason the villager npc's also start dissapearing again, I'll inform you.

Clean log on 1.10: https://www.dropbox.com/s/zyf1osavmq09h92/log.txt?dl=0

Sikatsu commented 8 years ago

Turns out the villagers are gone now too.

fullwall commented 8 years ago

@Sikatsu ok

Sikatsu commented 8 years ago

@fullwall

I really wonder what is causing this problem.

I also have a plugin which spawns an villager NPC, without the use of Citizens. This villager never dissapears.

fullwall commented 8 years ago

@Sikatsu - all I can do is try to get more debug log to narrow it down. https://dl.dropboxusercontent.com/u/6701575/citizens.jar this adds some more finegrained debugging info

Sikatsu commented 8 years ago

@fullwall Will test and give you a clean log.

Sikatsu commented 8 years ago

Is it normal that the file now renames himself to log.txt.1 and log.txt.2?

I removed log.txt.1 as I thought it was a bug, then it created log.txt.2 and log.txt.2.lck

fullwall commented 8 years ago

@Sikatsu yes I noticed that myself... haven't changed anything so it must be the way it works.

Sikatsu commented 8 years ago

@fullwall

Alright, 2 new fresh logs. I attach them both to be sure you have the logs where they did dissapear.

https://www.dropbox.com/s/wqllqi2m1m6dcuc/Citizens.rar?dl=0

fullwall commented 8 years ago

@Sikatsu sorry, still no luck... try getting debug from this https://dl.dropboxusercontent.com/u/6701575/citizens.jar

Sikatsu commented 8 years ago

@fullwall I will :)

Sikatsu commented 8 years ago

Sorry for the delay, 2 new fresh logs: https://www.dropbox.com/s/wqllqi2m1m6dcuc/Citizens.rar?dl=0

fullwall commented 8 years ago

@Sikatsu https://dl.dropboxusercontent.com/u/6701575/citizens.jar this one should give us some answers... sorry for the number of builds

Sikatsu commented 8 years ago

I guess plugman isn't supported so I have to wait till tonight before I can add that jar, will give you some fresh logs later tonight or tomorrow

Sikatsu commented 8 years ago

Didn't had much time yesterday.

New logs: https://www.dropbox.com/s/wqllqi2m1m6dcuc/Citizens.rar?dl=0

At around 5:00 theres a daily restart, however that's not the cause as they dissapear over mid day aswell.

fullwall commented 8 years ago

Another build sorry... seems to be related to keep-chunks-loaded at this stage (NPC not being spawned properly, something keeps trying to unload the chunk though) https://dl.dropboxusercontent.com/u/6701575/citizens.jar

Sikatsu commented 8 years ago

It's really hard as I can't restart in the middle of the day, to many players. Will do tonight and get you a fresh log around that time.

fullwall commented 8 years ago

No worries on timing

Sikatsu commented 8 years ago

Yesterday around 23:00 I restarted the server to update the Citizens jar, so between then and now they did dissapear.

https://www.dropbox.com/s/grcsxyjuyggspmx/log.rar?dl=0

fullwall commented 8 years ago

All the problematic NPCs are in the same chunk as 646 yes?

Sikatsu commented 8 years ago

No not really, 646 doesn't dissapear because it's a player NPC.

Around the same chunk with ID 643 and the chunk with ID 525.

fullwall commented 8 years ago

The NPC types disappearing are villager and armorstand?