Mark alerts as triggered in DB when timer > threshold_timer

[evelynleems]

Current problem: When citoengine receives multiple alerts of the same event within the same second, duplicated event actions are triggered.

How to replicate?

• Create an event action.
• Set Threshold Count to 1 and Threshold Timer to 60.
• Use event_publisher.py to send multiple alerts to citoengine within a second.
• You will notice the corresponding event action is triggered more than once.

Proposed Fix:

• Reorder the if-else statement in def is_action_required(self): if self.timer > self.event_action.threshold_timer has to be the first condition.
• Mark alert as triggered and save to database when threshold is reached (when timer exceeds configured threshold timing).

[coveralls]

Coverage decreased (-0.06%) to 65.721% when pulling 47d4701e8b644a86aa5da47dad5e8854d76c3225 on evelynleems:bugfix-alerts into a62dce3c76567dd36b7efcaa70e03728b335f44e on CitoEngine:master.

[coveralls]

Coverage increased (+0.1%) to 65.917% when pulling 220cb42a1d05a2c1361ce99b52d196cae56ab48f on evelynleems:bugfix-alerts into a62dce3c76567dd36b7efcaa70e03728b335f44e on CitoEngine:master.