Mark alerts as triggered in DB when timer > threshold_timer

evelynleems commented 7 years ago

Current problem: When citoengine receives multiple alerts of the same event within the same second, duplicated event actions are triggered.

How to replicate?

Create an event action.
Set Threshold Count to 1 and Threshold Timer to 60.
Use event_publisher.py to send multiple alerts to citoengine within a second.
You will notice the corresponding event action is triggered more than once.

Proposed Fix:

Reorder the if-else statement in def is_action_required(self): if self.timer > self.event_action.threshold_timer has to be the first condition.
Mark alert as triggered and save to database when threshold is reached (when timer exceeds configured threshold timing).

coveralls commented 7 years ago

Coverage increased (+0.1%) to 65.917% when pulling e458ffa15bac50b0c359e6b7c1d62b515f91c73c on evelynleems:bugfix-alerts into 61ad642cbac47c0164cfc85e9a1cb83e35caa8c5 on CitoEngine:develop.

coveralls commented 7 years ago

Coverage increased (+0.1%) to 65.917% when pulling da04cd7036999467bd28fcab3ec8f775b98c44de on evelynleems:bugfix-alerts into 61ad642cbac47c0164cfc85e9a1cb83e35caa8c5 on CitoEngine:develop.

extremeunix commented 7 years ago

Fixes #73

extremeunix commented 7 years ago

Thanks a lot @evelynleems 👍

CitoEngine / cito_engine

Mark alerts as triggered in DB when timer > threshold_timer #73