search

Citrinate / FreePackages

An ASF plugin for finding and redeeming free Steam games
Apache License 2.0
130 stars 7 forks source link

Do package filters impact performance? #6

Closed woctezuma closed 1 year ago

woctezuma commented 1 year ago

You allow to use package filters, which can be handy, e.g. if someone is only interested in F2P games which support Steam Trading Cards. However, I would like to know if package filters impact performance.

Does this lead to more requests being made for instance? In terms of web requests, is the most light-weight method to have no configuration setting except "EnableFreePackages": true,. Or is all the package information fetched anyway in the first place?

Citrinate commented 1 year ago

The plugin currently makes the same number of requests whether or not filters are enabled. The same data that's necessary to determine if something is free is also used to apply filters.

Citrinate commented 1 year ago

There's some optimizations I can do to reduce the number of requests if no bots are using filters, but only with regards to subs and not for apps. When these optimizations are implemented though, we're talking about an often 1 request difference between using filters and not using filters.

woctezuma commented 1 year ago

Thank you for the information! Then I can use filters without any afterthought!