CitrineInformatics / lolo

A random forest
Apache License 2.0
41 stars 12 forks source link

Feature: Strong typing in Lolo interfaces #300

Closed sfriedowitz closed 2 years ago

sfriedowitz commented 2 years ago

Consolidation of the following PRs: 1) https://github.com/CitrineInformatics/lolo/pull/294 2) https://github.com/CitrineInformatics/lolo/pull/295 3) https://github.com/CitrineInformatics/lolo/pull/296 4) https://github.com/CitrineInformatics/lolo/pull/297 5) https://github.com/CitrineInformatics/lolo/pull/298 6) https://github.com/CitrineInformatics/lolo/pull/299

sfriedowitz commented 2 years ago

The random build fails were due to SBT failing to download from Maven on the travis workers...which I can't imagine is related to my code changes. So I think this combo PR is ready to go.

StevenKauwe commented 2 years ago

Awesome! So all those separate PR were on this branch which is now on main! Makes sense why it was approved so fast.:D