Cleans up the dependencies in this repo. Specifically, this PR:
Replaces scrapy-sentry with our new sentry integration scrapy-sentry-errors.
Removes pywin32 dependency.
Installs city-scrapers-core from Github instead of PyPi.
Rebuilds pipenv.lock.
Why are we doing this?
These updates seem to be needed across most of the city-scraper repos in order to ensure they run smoothly. A number of our repos are failing to build seemingly due to dependency conflicts from outdated dependencies.
scrapy-sentry-errors is a new City Bureau-built Sentry integration that replaces scrapy-sentry. The latter appears to no longer be maintained and was causing clear build issues for some of the city-scraper repos. For more background, see PR 67 in city-scrapers-cle.
Steps to manually test
Build the repo locally and ensure it runs without errors.
CI tests should pass (but this should run automatically when this PR is created)
Are there any smells or added technical debt to note?
While it's not ideal, switching to installing city-scrapers-core directly from the GitHub repository instead of using our distributed package on PyPi may be necessary for now. Wheel files on PyPi are generally more optimized for installation. However, this method of installation seems to have helped resolve the dependency issues in other city-scraper repos. We plan to revert to installing from PyPi once city-scrapers-core has been updated and the dependencies are more manageable.
What's this PR do?
Cleans up the dependencies in this repo. Specifically, this PR:
scrapy-sentrywith our new sentry integrationscrapy-sentry-errors.pywin32dependency.city-scrapers-corefrom Github instead of PyPi.pipenv.lock.Why are we doing this?
These updates seem to be needed across most of the
city-scraperrepos in order to ensure they run smoothly. A number of our repos are failing to build seemingly due to dependency conflicts from outdated dependencies.scrapy-sentry-errors is a new City Bureau-built Sentry integration that replaces
scrapy-sentry. The latter appears to no longer be maintained and was causing clear build issues for some of thecity-scraperrepos. For more background, see PR 67 in city-scrapers-cle.Steps to manually test
Are there any smells or added technical debt to note?
While it's not ideal, switching to installing city-scrapers-core directly from the GitHub repository instead of using our distributed package on PyPi may be necessary for now. Wheel files on PyPi are generally more optimized for installation. However, this method of installation seems to have helped resolve the dependency issues in other city-scraper repos. We plan to revert to installing from PyPi once city-scrapers-core has been updated and the dependencies are more manageable.