City-Bureau / city-scrapers-cle

City Scrapers project for Cleveland
https://cityscrapers.org/
MIT License
15 stars 14 forks source link

🕷️ Fix spider: Cleveland Design Review Advisory Committees #107

Closed SimmonsRitchie closed 6 months ago

SimmonsRitchie commented 6 months ago

What's this PR do?

Fixes our Cleveland Design Review Advisory Committees spider (aka. cle_design_review). Also tweaks the description text for meetings.

Why are we doing this?

We want working scrapers, of course 🤖 This spider was breaking because when it parsed datetime information from the page it expect weekdays (eg. Thursday) to always be pluralized. This adjusts the handling so it can handle pluralized or non-pluralized forms.

It also reworks the description for each meeting so it's simpler and less dated (no longer are we referencing covid).

Steps to manually test

After installing the project using pipenv:

  1. Activate the virtual environment:

    pipenv shell
  2. Run the spider:

    scrapy crawl cle_design_review -O test_output.csv
  3. Monitor the stdout and ensure that the crawl proceeds without raising any errors. Pay attention to the final status report from scrapy.

  4. Inspect test_output.csv to ensure the data looks valid. I suggest opening a few of the URLs under the source column of test_output.csv and comparing the data for the row with what you see on the page.

Are there any smells or added technical debt to note?