City-Bureau / city-scrapers-cle

City Scrapers project for Cleveland
https://cityscrapers.org/
MIT License
15 stars 14 forks source link

Fix broken github actions reverting (Bump lxml from 4.6.2 to 4.6.3) #32

Closed skorasaurus closed 3 years ago

skorasaurus commented 3 years ago

Summary

After merging https://github.com/City-Bureau/city-scrapers-cle/commit/8d5cc872053bec01ab313dfc86fd126f4485a137;

the scraping github actions began to fail, for example: htps://github.com/City-Bureau/city-scrapers-cle/runs/4280842905?check_suite_focus=true

the error was the following:


[pipenv.exceptions.InstallError]: ERROR: No matching distribution found for pywin32==300
ERROR: Couldn't install package: pywin32
 Package installation failed...
Error: or]Process completed with exit code 1.

I figure that since none of the other scrapers' instances have merged the PR in yet; it would be best that we remain consistent with the other scrapers' instances and tackle this later if needed since there's no immediate concern.

Checklist

All checks are run in GitHub Actions. You'll be able to see the results of the checks at the bottom of the pull request page after it's been opened, and you can click on any of the specific checks listed to see the output of each step and debug failures.

Questions

Include any questions you have about what you're working on.

skorasaurus commented 3 years ago

DO NOT MERGE; I will rebase this and make a new PR once the tests are done.

skorasaurus commented 3 years ago

superseded by https://github.com/City-Bureau/city-scrapers-cle/pull/33 which has clean PR